Skip to content

[6.0] Fix dark theme issues with spy toggle and spy pane (#13345)#13399

Merged
stacey-gammon merged 1 commit intoelastic:6.0from
stacey-gammon:6.0/fix/dark-theme-spy-toggle
Aug 9, 2017
Merged

[6.0] Fix dark theme issues with spy toggle and spy pane (#13345)#13399
stacey-gammon merged 1 commit intoelastic:6.0from
stacey-gammon:6.0/fix/dark-theme-spy-toggle

Conversation

@stacey-gammon
Copy link

  • Fix dark theme issues with spy toggle and spy pane

  • Port dark theme portion of styling kuiIcon into uiFramework library

backports #13345

* Fix dark theme issues with spy toggle and spy pane

* Port dark theme portion of styling kuiIcon into uiFramework library
@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Aug 8, 2017
@stacey-gammon stacey-gammon merged commit 9a40ec7 into elastic:6.0 Aug 9, 2017
@stacey-gammon stacey-gammon deleted the 6.0/fix/dark-theme-spy-toggle branch October 24, 2017 13:57
hop-dev added a commit that referenced this pull request Aug 5, 2025
…0420)

## Summary

Closes [#13399](elastic/security-team#13399)

Fixes a bug where syncing privileged users from an index failed in
spaces other than "default".

The issue was that we could not find the API key saved object, this is
because we weren't specifying the namespace when we searched for it.

### Test Steps

- create a space "space2"
- switch to space2
- enable privileged usr monitoring advanced setting
- create an index to sync users from:

```
# create index with correct mapping
PUT /my-custom-index
{
  "mappings" : {
    "properties": {
      "user.name": {
        "type": "keyword"
      }
    }
  }
}

# add a user
POST /_bulk
{ "index": { "_index": "my-custom-index" } }
{ "user": { "name": "tiago" } }
```

- add a document to skip the onboarding screen

```
POST /logs-test-hello/_doc
{
  "message" : "sup"
}
```
- go to privileged user monitoring onbaording
- select your index to sync
- (it should work and load the users)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
…stic#230420)

## Summary

Closes [elastic#13399](elastic/security-team#13399)

Fixes a bug where syncing privileged users from an index failed in
spaces other than "default".

The issue was that we could not find the API key saved object, this is
because we weren't specifying the namespace when we searched for it.

### Test Steps

- create a space "space2"
- switch to space2
- enable privileged usr monitoring advanced setting
- create an index to sync users from:

```
# create index with correct mapping
PUT /my-custom-index
{
  "mappings" : {
    "properties": {
      "user.name": {
        "type": "keyword"
      }
    }
  }
}

# add a user
POST /_bulk
{ "index": { "_index": "my-custom-index" } }
{ "user": { "name": "tiago" } }
```

- add a document to skip the onboarding screen

```
POST /logs-test-hello/_doc
{
  "message" : "sup"
}
```
- go to privileged user monitoring onbaording
- select your index to sync
- (it should work and load the users)

(cherry picked from commit 6f9d1a3)
kibanamachine added a commit that referenced this pull request Aug 5, 2025
#230420) (#230563)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Entity Analytics][Privmon] Fix index sync in non-default spaces
(#230420)](#230420)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Mark
Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T12:04:06Z","message":"[Entity
Analytics][Privmon] Fix index sync in non-default spaces (#230420)\n\n##
Summary\n\nCloses
[#13399](https://github.com/elastic/security-team/issues/13399)\n\nFixes
a bug where syncing privileged users from an index failed in\nspaces
other than \"default\".\n\nThe issue was that we could not find the API
key saved object, this is\nbecause we weren't specifying the namespace
when we searched for it.\n\n### Test Steps\n\n- create a space
\"space2\"\n- switch to space2\n- enable privileged usr monitoring
advanced setting\n- create an index to sync users from:\n\n```\n# create
index with correct mapping\nPUT /my-custom-index\n{\n \"mappings\" : {\n
\"properties\": {\n \"user.name\": {\n \"type\": \"keyword\"\n }\n }\n
}\n}\n\n# add a user\nPOST /_bulk\n{ \"index\": { \"_index\":
\"my-custom-index\" } }\n{ \"user\": { \"name\": \"tiago\" } }\n```\n\n-
add a document to skip the onboarding screen\n\n```\nPOST
/logs-test-hello/_doc\n{\n \"message\" : \"sup\"\n}\n```\n- go to
privileged user monitoring onbaording\n- select your index to sync\n-
(it should work and load the
users)","sha":"6f9d1a3a323f939f1471c41bad856449f8f55ffd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","Team:Entity
Analytics","v9.2.0"],"title":"[Entity Analytics][Privmon] Fix index sync
in non-default
spaces","number":230420,"url":"https://github.com/elastic/kibana/pull/230420","mergeCommit":{"message":"[Entity
Analytics][Privmon] Fix index sync in non-default spaces (#230420)\n\n##
Summary\n\nCloses
[#13399](https://github.com/elastic/security-team/issues/13399)\n\nFixes
a bug where syncing privileged users from an index failed in\nspaces
other than \"default\".\n\nThe issue was that we could not find the API
key saved object, this is\nbecause we weren't specifying the namespace
when we searched for it.\n\n### Test Steps\n\n- create a space
\"space2\"\n- switch to space2\n- enable privileged usr monitoring
advanced setting\n- create an index to sync users from:\n\n```\n# create
index with correct mapping\nPUT /my-custom-index\n{\n \"mappings\" : {\n
\"properties\": {\n \"user.name\": {\n \"type\": \"keyword\"\n }\n }\n
}\n}\n\n# add a user\nPOST /_bulk\n{ \"index\": { \"_index\":
\"my-custom-index\" } }\n{ \"user\": { \"name\": \"tiago\" } }\n```\n\n-
add a document to skip the onboarding screen\n\n```\nPOST
/logs-test-hello/_doc\n{\n \"message\" : \"sup\"\n}\n```\n- go to
privileged user monitoring onbaording\n- select your index to sync\n-
(it should work and load the
users)","sha":"6f9d1a3a323f939f1471c41bad856449f8f55ffd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230420","number":230420,"mergeCommit":{"message":"[Entity
Analytics][Privmon] Fix index sync in non-default spaces (#230420)\n\n##
Summary\n\nCloses
[#13399](https://github.com/elastic/security-team/issues/13399)\n\nFixes
a bug where syncing privileged users from an index failed in\nspaces
other than \"default\".\n\nThe issue was that we could not find the API
key saved object, this is\nbecause we weren't specifying the namespace
when we searched for it.\n\n### Test Steps\n\n- create a space
\"space2\"\n- switch to space2\n- enable privileged usr monitoring
advanced setting\n- create an index to sync users from:\n\n```\n# create
index with correct mapping\nPUT /my-custom-index\n{\n \"mappings\" : {\n
\"properties\": {\n \"user.name\": {\n \"type\": \"keyword\"\n }\n }\n
}\n}\n\n# add a user\nPOST /_bulk\n{ \"index\": { \"_index\":
\"my-custom-index\" } }\n{ \"user\": { \"name\": \"tiago\" } }\n```\n\n-
add a document to skip the onboarding screen\n\n```\nPOST
/logs-test-hello/_doc\n{\n \"message\" : \"sup\"\n}\n```\n- go to
privileged user monitoring onbaording\n- select your index to sync\n-
(it should work and load the
users)","sha":"6f9d1a3a323f939f1471c41bad856449f8f55ffd"}}]}]
BACKPORT-->

Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
…stic#230420)

## Summary

Closes [elastic#13399](elastic/security-team#13399)

Fixes a bug where syncing privileged users from an index failed in
spaces other than "default".

The issue was that we could not find the API key saved object, this is
because we weren't specifying the namespace when we searched for it.

### Test Steps

- create a space "space2"
- switch to space2
- enable privileged usr monitoring advanced setting
- create an index to sync users from:

```
# create index with correct mapping
PUT /my-custom-index
{
  "mappings" : {
    "properties": {
      "user.name": {
        "type": "keyword"
      }
    }
  }
}

# add a user
POST /_bulk
{ "index": { "_index": "my-custom-index" } }
{ "user": { "name": "tiago" } }
```

- add a document to skip the onboarding screen

```
POST /logs-test-hello/_doc
{
  "message" : "sup"
}
```
- go to privileged user monitoring onbaording
- select your index to sync
- (it should work and load the users)
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…stic#230420)

## Summary

Closes [elastic#13399](elastic/security-team#13399)

Fixes a bug where syncing privileged users from an index failed in
spaces other than "default".

The issue was that we could not find the API key saved object, this is
because we weren't specifying the namespace when we searched for it.

### Test Steps

- create a space "space2"
- switch to space2
- enable privileged usr monitoring advanced setting
- create an index to sync users from:

```
# create index with correct mapping
PUT /my-custom-index
{
  "mappings" : {
    "properties": {
      "user.name": {
        "type": "keyword"
      }
    }
  }
}

# add a user
POST /_bulk
{ "index": { "_index": "my-custom-index" } }
{ "user": { "name": "tiago" } }
```

- add a document to skip the onboarding screen

```
POST /logs-test-hello/_doc
{
  "message" : "sup"
}
```
- go to privileged user monitoring onbaording
- select your index to sync
- (it should work and load the users)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant