Skip to content

Fix share to space flyout sizing #133949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix share to space flyout sizing #133949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions x-pack/plugins/spaces/public/share_saved_objects_to_space/components/alias_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,26 @@ export const AliasTable: FunctionComponent<Props> = ({ spaces, aliasesToDisable

return (
<>
<EuiCallOut
size="s"
title={
<EuiFlexItem grow={false}>
<EuiCallOut
size="s"
title={
<FormattedMessage
id="xpack.spaces.shareToSpace.aliasTableCalloutTitle"
defaultMessage="Legacy URL conflict"
/>
}
color="warning"
>
<FormattedMessage
id="xpack.spaces.shareToSpace.aliasTableCalloutTitle"
defaultMessage="Legacy URL conflict"
id="xpack.spaces.shareToSpace.aliasTableCalloutBody"
defaultMessage="{aliasesToDisableCount, plural, one {# legacy URL} other {# legacy URLs}} will be disabled."
values={{ aliasesToDisableCount }}
/>
}
color="warning"
>
<FormattedMessage
id="xpack.spaces.shareToSpace.aliasTableCalloutBody"
defaultMessage="{aliasesToDisableCount, plural, one {# legacy URL} other {# legacy URLs}} will be disabled."
values={{ aliasesToDisableCount }}
/>
</EuiCallOut>
</EuiCallOut>

<EuiSpacer size="m" />
<EuiSpacer size="m" />
</EuiFlexItem>

<EuiFlexItem>
<Suspense fallback={<EuiLoadingSpinner />}>
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_mode_control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const ShareModeControl = (props: Props) => {

const docLink = docLinks?.links.security.kibanaPrivileges;
return (
<>
<EuiFlexItem grow={false}>
<EuiCallOut
size="s"
iconType="help"
Expand Down Expand Up @@ -140,7 +140,7 @@ export const ShareModeControl = (props: Props) => {
</EuiCallOut>

<EuiSpacer size="m" />
</>
</EuiFlexItem>
);
};

Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

import './share_to_space_form.scss';

import { EuiCallOut, EuiLink, EuiSpacer } from '@elastic/eui';
import React, { Fragment } from 'react';
import { EuiCallOut, EuiFlexItem, EuiLink, EuiSpacer } from '@elastic/eui';
import React from 'react';

import { FormattedMessage } from '@kbn/i18n-react';

Expand Down Expand Up @@ -47,7 +47,7 @@ export const ShareToSpaceForm = (props: Props) => {
onUpdate({ ...shareOptions, selectedSpaceIds });

const createCopyCallout = showCreateCopyCallout ? (
<Fragment>
<EuiFlexItem grow={false}>
<EuiCallOut
size="s"
title={
Expand Down Expand Up @@ -75,7 +75,7 @@ export const ShareToSpaceForm = (props: Props) => {
</EuiCallOut>

<EuiSpacer size="m" />
</Fragment>
</EuiFlexItem>
) : null;

return (
Expand Down