[Shared UX] No data image placeholders#132376
Merged
cchaos merged 3 commits intoelastic:mainfrom May 18, 2022
Merged
Conversation
cchaos
added
Team:SharedUX
cchaos
added
the
release_note:skip
majagrubic
reviewed
May 18, 2022
| width: `max(100%, 360px)`, | ||
| height: 240, | ||
| objectFit: `cover`, | ||
| background: `aliceblue`, |
Contributor
There was a problem hiding this comment.
Just a nit: I don't think you need backticks here, regular '' should work.
Contributor
Author
There was a problem hiding this comment.
Yeah, usually my IDE converts these on save, wonder why it didnt. Fixed 2a33179
majagrubic
approved these changes
May 18, 2022
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Code review only, haven't tested it, but the changes look pretty straightforward and align with the video description.
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #132272 I noticed that the images we use in the no data cards and the no data views prompt don't have dimensions while the page is being loaded. This causes shifts in layout once the image is loaded. This PR gives these image components dimensions / dimensional fallbacks so that they don't cause these layout shifts.
BEFORE
CleanShot.2022-05-17.at.18.05.53.mp4
CleanShot.2022-05-17.at.18.11.05.mp4
AFTER
CleanShot.2022-05-17.at.18.02.50.mp4
CleanShot.2022-05-17.at.18.08.55.mp4
Checklist