[SharedUX] NoDataPage: open docs link in a new tab#132324
Merged
majagrubic merged 3 commits intoelastic:mainfrom May 18, 2022
Merged
[SharedUX] NoDataPage: open docs link in a new tab#132324majagrubic merged 3 commits intoelastic:mainfrom
majagrubic merged 3 commits intoelastic:mainfrom
Conversation
cchaos
approved these changes
May 17, 2022
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM, but while you're in here since I just clicked on the link in the storybook, can you change it from docs.com to at least docs.elastic.dev I think that the former may be a malicious site.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It was pointed here that we should be opening a docs link in a new tab, and I agree with that.
This PR adds a change to open docs link in a new tab to
NoDataPagecomponent.Checklist
Delete any items that are not applicable to this PR.
For maintainers