Skip to content

[SharedUX] NoDataPage: open docs link in a new tab#132324

Merged
majagrubic merged 3 commits intoelastic:mainfrom
majagrubic:no-data-external-link
May 18, 2022
Merged

[SharedUX] NoDataPage: open docs link in a new tab#132324
majagrubic merged 3 commits intoelastic:mainfrom
majagrubic:no-data-external-link

Conversation

@majagrubic
Copy link
Contributor

Summary

It was pointed here that we should be opening a docs link in a new tab, and I agree with that.
This PR adds a change to open docs link in a new tab to NoDataPage component.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@majagrubic majagrubic requested a review from a team May 17, 2022 13:08
@majagrubic majagrubic added v8.3.0 Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// release_note:skip Skip the PR/issue when compiling release notes labels May 17, 2022
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but while you're in here since I just clicked on the link in the storybook, can you change it from docs.com to at least docs.elastic.dev I think that the former may be a malicious site.

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 171.9KB 171.9KB +16.0B
securitySolution 5.0MB 5.0MB +16.0B
total +32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit 767983a into elastic:main May 18, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 18, 2022
@majagrubic majagrubic deleted the no-data-external-link branch May 18, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants