Skip to content

[Cloud Posture] add resource findings page flyout #132243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orouz merged 1 commit into from
May 17, 2022
Merged

[Cloud Posture] add resource findings page flyout #132243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 37 additions & 13 deletions .../pages/findings/latest_findings_by_resource/resource_findings/resource_findings_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,40 +4,64 @@
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { EuiEmptyPrompt, EuiBasicTable, CriteriaWithPagination, Pagination } from '@elastic/eui';
import React, { useMemo, useState } from 'react';
import {
EuiEmptyPrompt,
EuiBasicTable,
CriteriaWithPagination,
Pagination,
EuiBasicTableColumn,
EuiTableActionsColumnType,
} from '@elastic/eui';
import { extractErrorMessage } from '../../../../../common/utils/helpers';
import * as TEXT from '../../translations';
import type { ResourceFindingsResult } from './use_resource_findings';
import { getFindingsColumns } from '../../layout/findings_layout';
import { getExpandColumn, getFindingsColumns } from '../../layout/findings_layout';
import type { CspFinding } from '../../types';
import { FindingsRuleFlyout } from '../../findings_flyout/findings_flyout';

interface Props extends ResourceFindingsResult {
pagination: Pagination;
setTableOptions(options: CriteriaWithPagination<CspFinding>): void;
}

const columns = getFindingsColumns();

const ResourceFindingsTableComponent = ({
error,
data,
loading,
pagination,
setTableOptions,
}: Props) => {
const [selectedFinding, setSelectedFinding] = useState<CspFinding>();

const columns: [
EuiTableActionsColumnType<CspFinding>,
...Array<EuiBasicTableColumn<CspFinding>>
] = useMemo(
() => [getExpandColumn<CspFinding>({ onClick: setSelectedFinding }), ...getFindingsColumns()],
[]
);

if (!loading && !data?.page.length)
return <EuiEmptyPrompt iconType="logoKibana" title={<h2>{TEXT.NO_FINDINGS}</h2>} />;

return (
<EuiBasicTable
loading={loading}
error={error ? extractErrorMessage(error) : undefined}
items={data?.page || []}
columns={columns}
onChange={setTableOptions}
pagination={pagination}
/>
<>
<EuiBasicTable
loading={loading}
error={error ? extractErrorMessage(error) : undefined}
items={data?.page || []}
columns={columns}
onChange={setTableOptions}
pagination={pagination}
/>
{selectedFinding && (
<FindingsRuleFlyout
findings={selectedFinding}
onClose={() => setSelectedFinding(undefined)}
/>
)}
</>
Comment on lines +58 to +64
Copy link
Copy Markdown
Contributor Author

@orouz orouz May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later on i hope we'll manage to render just the table here and the flyout in the container.

);
};

Expand Down