Skip to content

[APM] Add kibana config for limiting the number of services in a service group #131929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 19, 2022
Merged

[APM] Add kibana config for limiting the number of services in a service group #131929

merged 21 commits into from
Jul 19, 2022

Conversation

@younesmln
Copy link
Contributor

@younesmln younesmln commented May 10, 2022 •
edited by kpatticha
Loading

Closes #131162

image

@younesmln younesmln changed the title [APM] Add kibana config for the limit of number of services in a service group [APM] Add kibana config for limiting the number of services in a service group May 10, 2022
@younesmln younesmln linked an issue May 10, 2022 that may be closed by this pull request
[APM] Add Kibana configuration to set max limit of services per service group #131162
Closed
@younesmln younesmln marked this pull request as ready for review May 10, 2022 15:04
@younesmln younesmln requested a review from a team as a code owner May 10, 2022 15:04
@younesmln younesmln added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 10, 2022
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 10, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented May 10, 2022

Pinging @elastic/apm-ui (Team:apm)

@younesmln younesmln added the backport:skip This PR does not require backporting label May 10, 2022
@younesmln younesmln requested a review from cauemarcondes May 10, 2022 17:32
gbamparop
gbamparop reviewed May 11, 2022
View reviewed changes
@younesmln younesmln requested a review from gbamparop May 11, 2022 12:15
@younesmln younesmln requested a review from dgieselaar May 16, 2022 12:53
@younesmln
Copy link
Contributor Author

younesmln commented May 19, 2022

@elasticmachine merge upstream

dgieselaar
dgieselaar reviewed May 20, 2022
View reviewed changes
x-pack/plugins/apm/server/routes/service_groups/route.ts Outdated
uiSettings: { client: uiSettingsClient },
} = await context.core;

const setup = await setupRequest(resources);
Copy link
Member

@dgieselaar dgieselaar May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can parallelize the call to uiSettings with setupRequest.

Copy link
Contributor Author

@younesmln younesmln May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2f050fb

@younesmln younesmln requested a review from dgieselaar May 23, 2022 11:38
@younesmln younesmln requested a review from dgieselaar May 23, 2022 13:00
dgieselaar
dgieselaar reviewed May 23, 2022
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@younesmln can you also use the setting in the following places:

@younesmln
Copy link
Contributor Author

younesmln commented May 23, 2022

@dgieselaar you referenced the same code twice! where you trying to refer to this one by any chance?

@dgieselaar
Copy link
Member

dgieselaar commented May 25, 2022

@younesmln yes, apologies for the late reply, missed this one :(

@younesmln
Copy link
Contributor Author

younesmln commented Jun 7, 2022

@elasticmachine merge upstream

@younesmln younesmln requested a review from dgieselaar June 8, 2022 00:19
@younesmln younesmln added v8.4.0 and removed v8.3.0 labels Jun 8, 2022
@younesmln
Copy link
Contributor Author

younesmln commented Jun 13, 2022

@elasticmachine merge upstream

@younesmln
Copy link
Contributor Author

younesmln commented Jun 15, 2022

@elasticmachine merge upstream

@younesmln
Copy link
Contributor Author

younesmln commented Jun 17, 2022

@elasticmachine merge upstream

@kpatticha
Copy link
Contributor

kpatticha commented Jul 18, 2022

@elasticmachine merge upstream

@kpatticha
Copy link
Contributor

kpatticha commented Jul 18, 2022

LGTM

@kpatticha
Copy link
Contributor

kpatticha commented Jul 19, 2022

buildkite test this

@kibana-ci
Copy link

kibana-ci commented Jul 19, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 383 385 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 64.0KB 64.2KB +225.0B
Unknown metric groups

API count

id before after diff
observability 386 388 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes
cauemarcondes approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpatticha kpatticha merged commit d5fe8e5 into elastic:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpatticha kpatticha kpatticha approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@gbamparop gbamparop Awaiting requested review from gbamparop

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Add Kibana configuration to set max limit of services per service group

9 participants

@younesmln @elasticmachine @dgieselaar @kpatticha @kibana-ci @gbamparop @cauemarcondes @kibanamachine @MiriamAparicio