Skip to content

[Shared UX] Create Analytics No Data Page package#131686

Merged
clintandrewhall merged 8 commits intoelastic:mainfrom
clintandrewhall:shared_ux/analytics_page
May 9, 2022
Merged

[Shared UX] Create Analytics No Data Page package#131686
clintandrewhall merged 8 commits intoelastic:mainfrom
clintandrewhall:shared_ux/analytics_page

Conversation

@clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented May 6, 2022

Builds on #130974

Summary

An entire page that can be displayed when Kibana "has no data", specifically for Analytics. It is provided as a package for consumption by Analytics solutions.

  • Encapsulates the existing services package so consumers won't have to change anything after they've converted.
    • This unblocks the conversion while other packages are created.
    • Legacy is used loosely, but can show the demarcation.
  • Consumers pass dataView, dataViewEditor and coreStart to the Provider wrapping their application.
    • We can certainly massage/reduce this before committing this PR, if necessary.
  • Storybook works.

Screen Shot 2022-05-06 at 1 12 41 AM

@clintandrewhall clintandrewhall added WIP Work in progress loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.3.0 labels May 6, 2022
@clintandrewhall clintandrewhall requested a review from a team May 6, 2022 06:13
@clintandrewhall clintandrewhall marked this pull request as draft May 6, 2022 06:13
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like this approach. Seems like the plugins will be able to use it with minimum overhead 🥳

@clintandrewhall clintandrewhall marked this pull request as ready for review May 7, 2022 03:30
@clintandrewhall clintandrewhall requested a review from a team May 7, 2022 03:31
@clintandrewhall clintandrewhall added review and removed WIP Work in progress labels May 7, 2022
@majagrubic
Copy link
Contributor

@elasticmachine merge upstream

@clintandrewhall clintandrewhall enabled auto-merge (squash) May 9, 2022 20:41
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-ux-page-analytics-no-data - 2 +2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/shared-ux-page-analytics-no-data - 3 +3
Unknown metric groups

API count

id before after diff
@kbn/shared-ux-page-analytics-no-data - 8 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit f7a2fb3 into elastic:main May 9, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* [Shared UX] Create Analytics No Data Page package

* Revise

* Add docs and tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@clintandrewhall clintandrewhall self-assigned this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants