Skip to content

Adding aria-label for discover data grid select document checkbox #131277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhavyarm merged 7 commits into from
May 3, 2022
Merged

Adding aria-label for discover data grid select document checkbox #131277

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f79c8ba
fix a11y label error
bhavyarm Apr 29, 2022
7150043
fixing missing aria-label
bhavyarm Apr 29, 2022
853acf6
Merge branch 'main' into updateLabelDiscoverGridCheckBox
bhavyarm Apr 29, 2022
d868519
Merge branch 'main' into updateLabelDiscoverGridCheckBox
bhavyarm May 2, 2022
6b30be4
Update src/plugins/discover/public/components/discover_grid/discover_…
bhavyarm May 3, 2022
4ad0bd4
Merge branch 'main' into updateLabelDiscoverGridCheckBox
bhavyarm May 3, 2022
a0e752d
Merge branch 'main' into updateLabelDiscoverGridCheckBox
bhavyarm May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/plugins/discover/public/components/discover_grid/discover_grid_document_selection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { euiLightVars as themeLight, euiDarkVars as themeDark } from '@kbn/ui-theme';
import { i18n } from '@kbn/i18n';
import { DiscoverGridContext } from './discover_grid_context';
import { ElasticSearchHit } from '../../types';

Expand All @@ -36,6 +37,11 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
const id = useMemo(() => getDocId(doc), [doc]);
const checked = useMemo(() => selectedDocs.includes(id), [selectedDocs, id]);

const toggleDocumentSelectionLabel = i18n.translate('discover.grid.selectDoc', {
defaultMessage: `Select document '{rowNumber}'`,
values: { rowNumber: rowIndex + 1 },
});

useEffect(() => {
if (expanded && doc && expanded._id === doc._id) {
setCellProps({
Expand All @@ -51,7 +57,7 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
return (
<EuiCheckbox
id={id}
label=""
aria-label={toggleDocumentSelectionLabel}
Comment thread
bhavyarm marked this conversation as resolved.
checked={checked}
data-test-subj={`dscGridSelectDoc-${id}`}
onChange={() => {
Expand Down