Skip to content

[Actionable Observability] consume tags filter#131220

Merged
mgiota merged 11 commits intoelastic:mainfrom
mgiota:127013_consume_shareable_tags_filter
May 13, 2022
Merged

[Actionable Observability] consume tags filter#131220
mgiota merged 11 commits intoelastic:mainfrom
mgiota:127013_consume_shareable_tags_filter

Conversation

@mgiota
Copy link
Copy Markdown
Contributor

@mgiota mgiota commented Apr 29, 2022 •
edited
Loading

Fixes #127013
Depends on #130710. Once dependent PR is merged, I can open up this one for review.
Screenshot 2022-05-10 at 10 34 37

@mgiota mgiota changed the title consume tags filter [Actionable Observability] consume tags filter Apr 29, 2022
@mgiota mgiota force-pushed the 127013_consume_shareable_tags_filter branch from 553da73 to 76d307e Compare May 9, 2022 08:33
@mgiota mgiota self-assigned this May 9, 2022
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 labels May 9, 2022
@mgiota mgiota marked this pull request as ready for review May 9, 2022 09:06
@mgiota mgiota requested a review from a team May 9, 2022 09:06
@mgiota
Copy link
Copy Markdown
Contributor Author

mgiota commented May 9, 2022

@elasticmachine merge upstream

@mgiota mgiota added the release_note:skip Skip the PR/issue when compiling release notes label May 9, 2022
@mgiota mgiota requested a review from a team as a code owner May 9, 2022 11:17
@mgiota mgiota requested a review from JiaweiWu May 9, 2022 19:25
JiaweiWu
JiaweiWu approved these changes May 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgiota mgiota requested a review from simianhacker May 10, 2022 09:11
@mgiota mgiota enabled auto-merge (squash) May 11, 2022 15:08
@mgiota
Copy link
Copy Markdown
Contributor Author

mgiota commented May 11, 2022

@elasticmachine merge upstream

@mgiota mgiota removed the request for review from simianhacker May 12, 2022 10:59
fkanout
fkanout requested changes May 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and it works as expected. One Small thing, add the missing type

Comment thread x-pack/plugins/observability/public/hooks/use_fetch_rules.ts Outdated
@mgiota @fkanout
Update x-pack/plugins/observability/public/hooks/use_fetch_rules.ts
7936212 
Co-authored-by: Faisal Kanout <faisal@kanout.com>
@mgiota mgiota requested a review from fkanout May 12, 2022 18:15
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 12, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 320 323 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 435.0KB 435.6KB +676.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
triggersActionsUi 28 29 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 100.8KB 100.9KB +48.0B
Unknown metric groups

API count

id before after diff
triggersActionsUi 334 337 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

@mgiota mgiota merged commit 1cc8c38 into elastic:main May 13, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 13, 2022
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request May 16, 2022
@mgiota @kibanamachine @Bamieh
[Actionable Observability] consume tags filter (elastic#131220)
74bf6cf 
* consume tags filter

* add getRuleTagFilter to the observability start mock

* use loadRuleTags instead of loadRuleAggregations

* add an error when rule tag fail to load

* load tags errors in a useEffect

* fix failing unit tests

* load rule errors in a useEffect

* stop loading loadRuleTagsAggs twice

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mgiota mgiota deleted the 127013_consume_shareable_tags_filter branch September 29, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkanout fkanout fkanout approved these changes

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees

@mgiota mgiota

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[o11y rules] Consume shareable filter per tags

5 participants

@mgiota @kibana-ci @fkanout @JiaweiWu @kibanamachine