Skip to content

[Actionable Observability] consume shareable status filter#131219

Merged
mgiota merged 7 commits intoelastic:mainfrom
mgiota:127015_consume_shareable_status_filter
May 4, 2022
Merged

[Actionable Observability] consume shareable status filter#131219
mgiota merged 7 commits intoelastic:mainfrom
mgiota:127015_consume_shareable_status_filter

Conversation

@mgiota
Copy link
Copy Markdown
Contributor

@mgiota mgiota commented Apr 29, 2022

Fixes #127015
Depends on #130705. Once dependent PR is merged, I can open up this one for review.

Screen.Recording.2022-05-04.at.10.51.29.mov

@mgiota mgiota mentioned this pull request Apr 29, 2022
9 tasks
@mgiota mgiota changed the title use shareable status filter [Actionable Observability] use shareable status filter Apr 29, 2022
@mgiota mgiota marked this pull request as ready for review May 4, 2022 08:38
@mgiota mgiota requested a review from a team as a code owner May 4, 2022 08:38
@mgiota mgiota requested a review from a team May 4, 2022 08:38
RuleType,
RuleTypeIndex,
RuleTypeModel,
RuleStatus,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiaweiWu Could you review this PR? It is a very small change that we already talked about here

#130705 (comment)

@mgiota mgiota requested a review from JiaweiWu May 4, 2022 08:40
@mgiota mgiota self-assigned this May 4, 2022
@mgiota mgiota requested a review from simianhacker May 4, 2022 08:41
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 release_note:skip Skip the PR/issue when compiling release notes labels May 4, 2022
@mgiota mgiota changed the title [Actionable Observability] use shareable status filter [Actionable Observability] consume shareable status filter May 4, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 393 392 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 443.0KB 442.7KB -245.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

Copy link
Copy Markdown
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgiota mgiota merged commit 47f4658 into elastic:main May 4, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 4, 2022
@mgiota mgiota deleted the 127015_consume_shareable_status_filter branch May 10, 2022 08:49
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…31219)

* use shareable status filter

* clean up and remove remnants from old status implementation

* bring back props

* fix more CI issues after renaming

* fix i118n issues

* fix failing unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[o11y Rules] Filter per status

5 participants