Upgrade EUI to v55.1.2 #131203

1Copenut · 2022-04-28T21:53:12Z

Summary

Added .render() calls to snapshot tests are intended to reduce the output of EUI components that use Emotion for styling. If you prefer the more verbose snapshot output in your plugin, we can remove the call.

`55.1.2`

Updated EuiOverlayMask to accept a React ref (#5876)

Bug fixes

Fixed EuiFlyout outsideClickCloses not being scoped to overlay mask when ownFocus=true (#5876)

`55.1.1`

Added the focusTrapProps prop to EuiFlyout to aid outside click detection and closing event (#5860)

`55.1.0`

Improved EuiTimeline a11y by using better semantic elements (#5791)
Replaced sass usage in EuiAspectRatio with inline styles using aspect-ratio property of css (#5818)
Improved accessibility of EuiLoadingChart (#5821)
Added euiFontSize() and useEuiFontSize() JS function and React hook for font sizing (#5822)
Added levels object to EuiTheme (#5827)
Updated the use of @emotion/cache to include all @emotion styles (#5831)

Bug fixes

Fixed layout bug in EuiAccordion children that use position: fixed; (#5806)
Fixed EuiFlyout so that it no longer closes when a click starts inside the flyout but completes outside (#5810)
Fixed EuiBasicTable mobile styles being in sync between JS and Sass (#5822)

CSS-in-JS conversions

Converted EuiSpacer to Emotion; Removed $spacerSizes (#5812)
Converted EuiBeacon to Emotion (#5814)
Changed euiCanAnimate to a constant (#5814)
Converted EuiHorizontalRule to emotion; Removed $ruleMargins (#5815)
Converted EuiLoadingChart to Emotion (#5821)

* Updating package.json to latest EUI * Adding one translation.

1Copenut · 2022-04-29T13:38:34Z

@elasticmachine merge upstream

…f-by-one error.

YulNaumenko

Security Solution changes LGTM

shahzad31

Uptime changes LGTM !!

cnasikas

ResponseOps changes LGTM

jughosta · 2022-05-10T08:29:47Z

src/plugins/discover/public/services/doc_views/components/doc_viewer_source/source.test.tsx

      </KibanaContextProvider>
    );
-    expect(comp.children()).toMatchSnapshot();
+    expect(comp.children().render()).toMatchSnapshot();


Data Discovery would like to revert changes in src/plugins/discover/public/services/doc_views/components/doc_viewer_source/source.test.tsx and source.test.tsx.snap otherwise the functionality which tests are checking is excluded in snapshots.

@jughosta I removed the render() call and updated the snapshot. CI build is running now.

efegurkan

Enterprise Search Changes looks good, tested locally.

afharo · 2022-05-10T13:56:49Z

src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap

-    button={<button />}
+Array [
+  <button
+    aria-controls="collapsibe-nav"


Is this a typo? Shouldn't it be collapsible?

I can't speak to it shoudl being collapsible but don't believe it's a typo. If the "collapsible-nav" id didn't exist, a11y tests would throw an error.

That was not introduced by the upgrade anyway, see line 313 of the old version of this file, so I think we're fine

jughosta

Data Discovery changes look good!

peteharverson

ML code changes LGTM

paul-tavares

Files under x-pack/plugins/security_solution/public/management/* LGTM 👍

ThomThomson

The smaller snapshots are great! LGTM!

thompsongl · 2022-05-11T20:21:44Z

@elasticmachine merge upstream

kibana-ci · 2022-05-11T21:34:48Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.8MB	-5.0B
`cases`	296.7KB	296.7KB	-15.0B
`fleet`	704.6KB	704.6KB	-15.0B
`indexManagement`	515.5KB	515.5KB	+6.0B
`securitySolution`	4.8MB	4.8MB	-50.0B
total			-79.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	300.0KB	300.1KB	+106.0B
`kbnUiSharedDeps-css`	594.5KB	589.9KB	-4.5KB
`kbnUiSharedDeps-npmDll`	4.8MB	4.8MB	+3.0KB
`newsfeed`	9.9KB	10.0KB	+131.0B
total			-1.3KB

History

💚 Build #43674 succeeded a913528
💚 Build #43422 succeeded cf66938
💛 Build #43377 was flaky c4d5092
💔 Build #43364 failed de1b7aa
💔 Build #42620 failed 41279a1
💔 Build #42583 failed 7645d35

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

thompsongl · 2022-05-11T21:54:56Z

@elastic/kibana-reporting-services @elastic/kibana-app-services @elastic/apm-ui @joeypoon

We'll plan on merging this by EOD May 12. Please get your reviews in before then 🙇

joeypoon

👌 for OLM

pgayvallet · 2022-05-12T12:05:57Z

src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap

-    button={<button />}
+Array [
+  <button
+    aria-controls="collapsibe-nav"


That was not introduced by the upgrade anyway, see line 313 of the old version of this file, so I think we're fine

Dosant

App services tests/snapshot changes lgmt 👍

tsullivan

Reporting changes LGTM

* Bumping EUI to v55.1.0 * Updating package.json to latest EUI * Adding one translation. * Updating theme config to pass Jest Tests elastic#4 / CaseView. * Updating theme config to pass Jest Tests 3, CauseStacktrace. * Updating six x-pack synthetic test snapshots. * Updating snapshots for discover, reporting, security_solution. * Replacing instances of spacerSizes with euiSize. * Updating a number of snapshots for Emotion styles. * Adding more snapshots for Emotion style upgrade. * Updating seven snapshot tests for Emotion styles. * Updating two snapshot tests for Emotion styles. * Adding two more snapshots for License and Upload. * Updating a Typescript check, and classname count in one unit test. * Updating 1 snapshot and refining EuiLoadingChart selector to avoid off-by-one error. * Bumping EUI to 55.1.1 for a change in EUI Flyout behavior. * update newsfeed flyout to use shards * snapshot update * eui to v55.1.2 * update onClose * onClose types * reduce snapshot noise * reduce snapshot noise * Adding back Emotion output at request of Data Discovery reviewer. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Greg Thompson <[email protected]>

Bumping EUI to v55.1.0

a8e0daa

* Updating package.json to latest EUI * Adding one translation.

1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting ci:deploy-cloud v8.3.0 labels Apr 28, 2022

1Copenut self-assigned this Apr 28, 2022

kibanamachine and others added 22 commits April 29, 2022 08:38

Merge branch 'main' into eui/55.1.0

3bfcb83

Merge remote-tracking branch 'upstream/main' into eui/55.1.0

7c985d7

Updating theme config to pass Jest Tests #4 / CaseView.

2a2279d

Merge branch 'eui/55.1.0' of github.com:1Copenut/kibana into eui/55.1.0

d804e37

Updating theme config to pass Jest Tests 3, CauseStacktrace.

3650582

Updating six x-pack synthetic test snapshots.

2ff1458

Updating snapshots for discover, reporting, security_solution.

aa22c09

Replacing instances of spacerSizes with euiSize.

e976fcf

Updating a number of snapshots for Emotion styles.

80739c7

Adding more snapshots for Emotion style upgrade.

eb3cab4

Merge remote-tracking branch 'upstream/main' into eui/55.1.0

283ffd8

Updating seven snapshot tests for Emotion styles.

d3813f4

Updating two snapshot tests for Emotion styles.

03e16b9

Merge remote-tracking branch 'upstream/main' into eui/55.1.0

4bba32e

Adding two more snapshots for License and Upload.

792d955

Updating a Typescript check, and classname count in one unit test.

e00f4ff

Merge remote-tracking branch 'upstream/main' into eui/55.1.0

89cc872

Updating 1 snapshot and refining EuiLoadingChart selector to avoid of…

651d85e

…f-by-one error.

Bumping EUI to 55.1.1 for a change in EUI Flyout behavior.

25fd304

update newsfeed flyout to use shards

7645d35

snapshot update

3833111

Merge branch 'main' into eui/55.1.0

41279a1

thompsongl added 2 commits May 9, 2022 12:41

reduce snapshot noise

c202a8f

reduce snapshot noise

cf66938

YulNaumenko approved these changes May 9, 2022

View reviewed changes

shahzad31 approved these changes May 9, 2022

View reviewed changes

cnasikas approved these changes May 9, 2022

View reviewed changes

jughosta reviewed May 10, 2022

View reviewed changes

sabarasaba approved these changes May 10, 2022

View reviewed changes

efegurkan approved these changes May 10, 2022

View reviewed changes

azasypkin approved these changes May 10, 2022

View reviewed changes

Adding back Emotion output at request of Data Discovery reviewer.

a913528

afharo reviewed May 10, 2022

View reviewed changes

jughosta approved these changes May 10, 2022

View reviewed changes

peteharverson approved these changes May 10, 2022

View reviewed changes

paul-tavares approved these changes May 11, 2022

View reviewed changes

klacabane approved these changes May 11, 2022

View reviewed changes

ThomThomson approved these changes May 11, 2022

View reviewed changes

Merge branch 'main' into eui/55.1.0

52d487f

joeypoon approved these changes May 11, 2022

View reviewed changes

dgieselaar approved these changes May 12, 2022

View reviewed changes

pgayvallet approved these changes May 12, 2022

View reviewed changes

Dosant approved these changes May 12, 2022

View reviewed changes

tsullivan approved these changes May 12, 2022

View reviewed changes

1Copenut merged commit 05ead15 into elastic:main May 12, 2022

1Copenut deleted the eui/55.1.0 branch May 12, 2022 21:14

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Upgrade EUI to v55.1.2 #131203

Upgrade EUI to v55.1.2 #131203

Uh oh!

Conversation

1Copenut commented Apr 28, 2022 • edited by thompsongl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

1Copenut commented Apr 29, 2022

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

efegurkan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented May 11, 2022

Uh oh!

kibana-ci commented May 11, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

thompsongl commented May 11, 2022

Uh oh!

joeypoon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

25 participants

1Copenut commented Apr 28, 2022 •

edited by thompsongl

Loading