[Infra Monitoring]: add rac to feature privileges for logs and metrics#130762
Merged
mgiota merged 1 commit intoelastic:mainfrom Apr 21, 2022
Merged
[Infra Monitoring]: add rac to feature privileges for logs and metrics#130762mgiota merged 1 commit intoelastic:mainfrom
mgiota merged 1 commit intoelastic:mainfrom
Conversation
matschaffer
approved these changes
Apr 21, 2022
Contributor
matschaffer
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Should we add something similar to https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/server/plugin.ts#L269 ? I don't see an api privilege there today, so not sure.
Contributor
Author
@matschaffer Good point! I don't think we need to do something to this file at the moment, since stack monitoring rule types are not RAC registered yet as far as I know. But something we should definitely need to keep in mind, when we port stack monitoring rule types to alerts as data indices! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130761
Notes for the reviewer
Forbidden errorwhen they had the option to Update theworkflow_statusin the Alerts Page https://github.com/elastic/sdh-kibana/issues/2798.7.17.4Mark as acknowledgedandMark as closedoptions have been removed from the alerts view in 8.0 [8.0][RAC] 117686 replace alert workflow status in alerts view #118723, you won't be able to reproduce the bug on main, but still rac privileges need to be present to avoid any future privilege related bugsQuestion
Shall we backport this fix to releases previous to
7.17.4as well?Update: Based on #111296, RAC feature flags were disabled by default for 7.15 and 7.16, so I would say we don't need to backport at all?