Skip to content

[Infra Monitoring]: add rac to feature privileges for logs and metrics#130762

Merged
mgiota merged 1 commit intoelastic:mainfrom
mgiota:130761_rac_privilege_logs_metrics
Apr 21, 2022
Merged

[Infra Monitoring]: add rac to feature privileges for logs and metrics#130762
mgiota merged 1 commit intoelastic:mainfrom
mgiota:130761_rac_privilege_logs_metrics

Conversation

@mgiota
Copy link
Copy Markdown
Contributor

@mgiota mgiota commented Apr 21, 2022

Fixes #130761

Screenshot 2022-04-20 at 21 03 51

Notes for the reviewer

Question

Shall we backport this fix to releases previous to 7.17.4 as well?
Update: Based on #111296, RAC feature flags were disabled by default for 7.15 and 7.16, so I would say we don't need to backport at all?

@mgiota mgiota requested a review from a team as a code owner April 21, 2022 04:53
@mgiota mgiota self-assigned this Apr 21, 2022
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 bug Fixes for quality problems that affect the customer experience Theme: rac label obsolete release_note:skip Skip the PR/issue when compiling release notes labels Apr 21, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

Copy link
Copy Markdown
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Should we add something similar to https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/server/plugin.ts#L269 ? I don't see an api privilege there today, so not sure.

@mgiota
Copy link
Copy Markdown
Contributor Author

mgiota commented Apr 21, 2022

Should we add something similar to https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/server/plugin.ts#L269 ?

@matschaffer Good point! I don't think we need to do something to this file at the moment, since stack monitoring rule types are not RAC registered yet as far as I know. But something we should definitely need to keep in mind, when we port stack monitoring rule types to alerts as data indices!

@mgiota mgiota merged commit bb9fc4b into elastic:main Apr 21, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 21, 2022
@mgiota mgiota deleted the 130761_rac_privilege_logs_metrics branch May 10, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Infra Monitoring] Add rac to feature privileges for logs and metrics

4 participants