Skip to content

[7.17] [Observability] [RAC] [Alerts] Resolve bug where "mark as.." for a single alert would redirect to security solution route #130609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhurley14 merged 5 commits into from
Apr 20, 2022
Merged

[7.17] [Observability] [RAC] [Alerts] Resolve bug where "mark as.." for a single alert would redirect to security solution route #130609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5844e7
resolves bug where a user updating a single alert in observability us…
dhurley14 Apr 19, 2022
e17125b
Merge remote-tracking branch 'upstream/7.17' into hotfix-single-updat…
dhurley14 Apr 19, 2022
13141e9
fix forbidden error
mgiota Apr 20, 2022
73b7d83
fix test
dhurley14 Apr 20, 2022
4cd5ada
Merge remote-tracking branch 'origin/hotfix-single-update-alerts-obs'…
dhurley14 Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/plugins/infra/server/features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const METRICS_FEATURE = {
all: {
app: ['infra', 'metrics', 'kibana'],
catalogue: ['infraops', 'metrics'],
api: ['infra'],
api: ['infra', 'rac'],
savedObject: {
all: ['infrastructure-ui-source'],
read: ['index-pattern'],
Expand All @@ -50,7 +50,7 @@ export const METRICS_FEATURE = {
read: {
app: ['infra', 'metrics', 'kibana'],
catalogue: ['infraops', 'metrics'],
api: ['infra'],
api: ['infra', 'rac'],
savedObject: {
all: [],
read: ['infrastructure-ui-source', 'index-pattern'],
Expand Down Expand Up @@ -88,7 +88,7 @@ export const LOGS_FEATURE = {
all: {
app: ['infra', 'logs', 'kibana'],
catalogue: ['infralogging', 'logs'],
api: ['infra'],
api: ['infra', 'rac'],
savedObject: {
all: ['infrastructure-ui-source'],
read: [],
Expand All @@ -109,7 +109,7 @@ export const LOGS_FEATURE = {
read: {
app: ['infra', 'logs', 'kibana'],
catalogue: ['infralogging', 'logs'],
api: ['infra'],
api: ['infra', 'rac'],
alerting: {
rule: {
read: [LOG_DOCUMENT_COUNT_ALERT_TYPE_ID],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/timelines/public/hooks/use_status_bulk_action_items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const useStatusBulkActionItems = ({
setEventsDeleted,
onUpdateSuccess,
onUpdateFailure,
timelineId,
timelineId = STANDALONE_ID,
}: StatusBulkActionsProps) => {
const { updateAlertStatus } = useUpdateAlertsStatus(timelineId !== STANDALONE_ID);
const { addSuccess, addError, addWarning } = useAppToasts();
Expand Down
17 changes: 17 additions & 0 deletions x-pack/test/observability_functional/apps/observability/alerts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,23 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
expect(enabledCheckBoxes.length).to.eql(3);
});
});

it('validate functionality of the single alert actions button', async () => {
await observability.alerts.common.setWorkflowStatusFilter('acknowledged');
const singleActions = await testSubjects.findAll('alerts-table-row-action-more');
await singleActions[0].click();

const closeAlertAction = await testSubjects.find('close-alert-status');
await closeAlertAction.click();

await observability.alerts.common.setWorkflowStatusFilter('acknowledged');

await retry.try(async () => {
const enabledCheckBoxes =
await observability.alerts.common.getAllEnabledCheckBoxInTable();
expect(enabledCheckBoxes.length).to.eql(2);
});
});
});
});
});
Expand Down