[Uptime] monitor management - adjust sort field map for inline monitor errors#130606
Merged
dominiqueclarke merged 2 commits intoelastic:mainfrom Apr 20, 2022
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
I did create a monitor per the instructions but it did not show as invalid.
Contributor
Author
Discussed offline that this is due to an issue with your system clock. |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
POST FF Testing: |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…r errors (elastic#130606) * uptime - monitor management - adjust sort field map for inline monitor errors * add additional field to sortFieldMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #130433 we implemented multi fields for some of our monitor saved object properties and implemented sorting based on the
.keywordfield mapped totype: keyword. This PR adjusts thesortFieldMapto reflect those changes. Without this change, inline monitor errors is broken and monitors will never appear as invalid.Testing