Skip to content

[Uptime] monitor management - adjust sort field map for inline monitor errors#130606

Merged
dominiqueclarke merged 2 commits intoelastic:mainfrom
dominiqueclarke:fix/uptime-invalid-monitors
Apr 20, 2022
Merged

[Uptime] monitor management - adjust sort field map for inline monitor errors#130606
dominiqueclarke merged 2 commits intoelastic:mainfrom
dominiqueclarke:fix/uptime-invalid-monitors

Conversation

@dominiqueclarke
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke commented Apr 19, 2022

Summary

In #130433 we implemented multi fields for some of our monitor saved object properties and implemented sorting based on the .keyword field mapped to type: keyword. This PR adjusts the sortFieldMap to reflect those changes. Without this change, inline monitor errors is broken and monitors will never appear as invalid.

Testing

  1. Add the following keys to Kibana.yml https://p.elstc.co/paste/1wHk4Wyl#TsgkPH0nf0Km5FUl0-W2SxbU9WHzIRa2+THKNfyMpar
  2. Navigate to Monitor Management. Click Add Monitor
  3. Add a browser monitor with the following script
step('Go to https://www.elastic.co/', async () => {
  await page.goto('https://www.elastic.co/');
};
  1. Navigate to Uptime. Wait for the monitor result to come back in.
  2. Navigate back to Monitor Management. You should see 1 invalid monitor

Screen Shot 2022-04-19 at 3 57 16 PM

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 19, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 19, 2022 19:57
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did create a monitor per the instructions but it did not show as invalid.

@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

I did create a monitor per the instructions but it did not show as invalid.

Discussed offline that this is due to an issue with your system clock.

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 777.2KB 777.3KB +50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 18aa549 into elastic:main Apr 20, 2022
@dominiqueclarke dominiqueclarke deleted the fix/uptime-invalid-monitors branch April 20, 2022 02:53
kibanamachine pushed a commit that referenced this pull request Apr 20, 2022
…r errors (#130606)

* uptime - monitor management - adjust sort field map for inline monitor errors

* add additional field to sortFieldMap

(cherry picked from commit 18aa549)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 20, 2022
…r errors (#130606) (#130632)

* uptime - monitor management - adjust sort field map for inline monitor errors

* add additional field to sortFieldMap

(cherry picked from commit 18aa549)

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@shahzad31
Copy link
Copy Markdown
Contributor

POST FF Testing:
Works as expected, fixes the issue

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…r errors (elastic#130606)

* uptime - monitor management - adjust sort field map for inline monitor errors

* add additional field to sortFieldMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants