Skip to content

Update dependency color to ^4.2.3 (main)#130079

Merged
alexwizp merged 5 commits intoelastic:mainfrom
alexwizp:update-color
Apr 18, 2022
Merged

Update dependency color to ^4.2.3 (main)#130079
alexwizp merged 5 commits intoelastic:mainfrom
alexwizp:update-color

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

Summary

This PR contains the following updates:

  • update color package from version 1.0.3 -> ^4.2.3
  • update @types/color from version ^3.0.0 -> ^3.0.3

@alexwizp alexwizp requested review from flash1293 and stratoula April 13, 2022 08:31
@alexwizp alexwizp self-assigned this Apr 13, 2022
@alexwizp alexwizp added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.3.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 13, 2022
@alexwizp alexwizp marked this pull request as ready for review April 13, 2022 09:07
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@stratoula
Copy link
Copy Markdown
Contributor

I have tested all visualizations and the color handling parts. Everything seems to work fine!
@elastic/infra-monitoring-ui do you want to also have a look that the upgrade doesn't cause any problem as I can see that you also use this library?

I checked the changelog and I dont see anything alarming.

@stratoula stratoula requested a review from a team April 14, 2022 09:23
@alexwizp
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 115 114 -1
expressionPartitionVis 55 54 -1
infra 941 940 -1
lens 763 762 -1
visTypeTimeseries 302 301 -1
total -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 47.1KB 44.0KB -3.2KB
infra 1005.7KB 1002.5KB -3.2KB
lens 1.1MB 1.1MB -3.2KB
visTypeTimeseries 470.7KB 467.5KB -3.2KB
total -12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 61.5KB 58.3KB -3.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp
Copy link
Copy Markdown
Contributor Author

@elastic/infra-monitoring-ui will merge it. Please in case of any objections let me know

@alexwizp alexwizp merged commit 123b231 into elastic:main Apr 18, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants