You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Motivation:
After PR #127651 is merged, next step is move the autocomplete folder to the unified_search plugin. No extra functionality is going to be added (or cleanups or improvements).
What was done:
data/plugin/autocomplete folder was moved into unified_search;
data/plugin/server/autocomplete folder was moved into unified_search;
The following part was moved from from the Data Plugin runtime contract to UnifiedSearch Plugin
autocomplete: this.autocomplete.start(),
Related Static and Runtime imports were updated
Added the unifiedSearch plugin as a dependency to plugins that require plugins (Kibana.json)
Registered a unifiedSearch plugin in the i18n (translations) plugin
data/server/config_deprecations.ts file was moved into unified_search/server and added renameFromRoot for autocomplete;
nlatipov
changed the title
Issue move autocomplete to unified search
[Unified Search] Move autocomplete logic to unified search plugin
Apr 8, 2022
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is solves Issue: #128383
Motivation:
After PR #127651 is merged, next step is move the autocomplete folder to the unified_search plugin. No extra functionality is going to be added (or cleanups or improvements).
What was done:
data/plugin/autocompletefolder was moved intounified_search;data/plugin/server/autocompletefolder was moved intounified_search;Data Pluginruntime contract toUnifiedSearch PluginStaticandRuntimeimports were updateddata/server/config_deprecations.tsfile was moved intounified_search/serverand added renameFromRoot for autocomplete;