Remove invalid syntax from .eslintrc.js#129164
Merged
watson merged 2 commits intoelastic:mainfrom Apr 4, 2022
Merged
Conversation
The exclamation mark prefix doesn't have any effect in the `files` list. You instead need to override the matched path later with a different rule in order to change the behavior.
watson
added
release_note:skip
jbudz
approved these changes
Apr 1, 2022
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
plugins/ and packages/elastic-eslint-config-kibana are already in .eslintignore too. Sounds like the datemath package is good. LGTM
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 4, 2022
The exclamation mark prefix doesn't have any effect in the `files` list. You instead need to override the matched path later with a different rule in order to change the behavior. (cherry picked from commit 98306f1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 4, 2022
The exclamation mark prefix doesn't have any effect in the `files` list. You instead need to override the matched path later with a different rule in order to change the behavior. (cherry picked from commit 98306f1) Co-authored-by: Thomas Watson <watson@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exclamation mark prefix doesn't have any effect in the
fileslist. You instead need to override the matched path later with a different rule in order to change the behavior.I've verified this manually by commenting out the specific license rule for
packages/elastic-datemathbelow this one and seen that in fact this rule is run for that path even though it's supposed to not include it.I've not been able to find any ESLint documentation saying anything about this kind of syntax in this place.