Skip to content

define configuration to expose to the browser#128938

Merged
klacabane merged 1 commit intoelastic:mainfrom
klacabane:123269-sm-expose-to-browser
Mar 30, 2022
Merged

define configuration to expose to the browser#128938
klacabane merged 1 commit intoelastic:mainfrom
klacabane:123269-sm-expose-to-browser

Conversation

@klacabane
Copy link
Copy Markdown
Contributor

@klacabane klacabane commented Mar 30, 2022

Summary

Closes #123269

Define a nested configuration to the exposeToBrowser option to restrict the shared settings to the strict minimum.

@klacabane klacabane added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v7.17.2 v8.1.2 labels Mar 30, 2022
@klacabane klacabane marked this pull request as ready for review March 30, 2022 16:11
@klacabane klacabane requested a review from a team as a code owner March 30, 2022 16:11
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Copy link
Copy Markdown
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane klacabane merged commit e2e63c7 into elastic:main Mar 30, 2022
kibanamachine pushed a commit that referenced this pull request Mar 30, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.1

Manual backport

To create the backport manually run:

node scripts/backport --pr 128938

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

klacabane added a commit to klacabane/kibana that referenced this pull request Mar 30, 2022
(cherry picked from commit e2e63c7)

# Conflicts:
#	x-pack/plugins/monitoring/server/index.ts
kibanamachine added a commit that referenced this pull request Mar 30, 2022
(cherry picked from commit e2e63c7)

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
klacabane added a commit that referenced this pull request Mar 30, 2022
(cherry picked from commit e2e63c7)

# Conflicts:
#	x-pack/plugins/monitoring/server/index.ts
klacabane added a commit to klacabane/kibana that referenced this pull request Mar 31, 2022
klacabane added a commit that referenced this pull request Mar 31, 2022
@klacabane klacabane added v7.17.3 and removed v7.17.2 labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Stack Monitoring release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.17.3 v8.1.2 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stack monitoring] Do not expose monitoring.ui.elasticsearch configuration to the browser

5 participants