[RAM] Add error logs in rule details page by XavierM · Pull Request #128925 · elastic/kibana

XavierM · 2022-03-30T15:31:55Z

Summary

Adding error log tabs to show the latest error between execution and actions
bringing our new way to snooze on the details page [RAM] Add Snooze dropdown control to Rule Details page #128302
clean up the call out to match the rule list page
Rule run history and alerts tabs are not displayed when the rule is disabled #129121 (comment)

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2022-03-30T15:31:58Z

Pinging @elastic/response-ops (Team:ResponseOps)

JiaweiWu

I tested the error logs locally, everything looks good, other than the comments that I left

I'll let someone else give the green light for the snooze section.

...iggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx

JiaweiWu · 2022-03-31T21:14:10Z

...ins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx

+              onRuleChanged={requestRefresh}
+              direction="row"
+              isEditable={hasEditButton}
+              previousSnoozeInterval={null}


do we need to specifically pass in null here?

Yes because we are not going to backport this feature for 8.2, so I will have to remove it. But I think that we should also move the code out of the rule list page to RuleStatusDropdown, therefore we are not duplicating this functionality everywhere we used this component. We will follow up with a new PR.

...s/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx

JiaweiWu · 2022-03-31T21:29:34Z

...s/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx

+        sorting={{ sort }}
+        pagination={pagination}
+        onChange={({ page: changedPage, sort: changedSort }) => {
+          if (changedPage) {


not really a big deal, but should we break this into onChangePage and onChangeSort functions?

...ggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx

ymao1

Error log table looks good! Left some comments about the updated error/warning banners.

...ugins/triggers_actions_ui/public/application/lib/rule_api/load_execution_log_aggregations.ts

...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx

x-pack/plugins/alerting/common/execution_log_types.ts

...ins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx

...ck/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule.scss

JiaweiWu

LGTM, but just wanted to make sure that we are only disabling the last response, and not the average duration or execution duration graph

Also do we want a more detailed wording for the disabled messaging? Since the old messaging explained why the rule summary couldn't be display, this just says "disabled"

XavierM · 2022-04-01T20:51:50Z

@JiaweiWu I worked with @ryankeairns and here we go

Issue was fixed, but didn't do a review.

ryankeairns · 2022-04-01T21:39:18Z

Design PR

Merge at your leisure:
👉 XavierM#10

Design tweaks to header, status dropdown, mobile

…-error-logs

ymao1

Just some comments about the types and the sorting issue discussed offline and this LGTM!

x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.test.ts

x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts

kibana-ci · 2022-04-02T14:44:56Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #1 / APM API tests trial apm_mappings_only_8.0.0 fetching service anomalies with a trial license checks if alert is active

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	358	359	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`alerting`	317	326	+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	700.3KB	697.7KB	-2.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`alerting`	21	20	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	98.6KB	98.6KB	-4.0B

Unknown metric groups

API count

id	before	after	diff
`alerting`	325	334	+9

async chunk count

id	before	after	diff
`triggersActionsUi`	73	75	+2

ESLint disabled line counts

id	before	after	diff
`triggersActionsUi`	160	164	+4

Total ESLint disabled count

id	before	after	diff
`triggersActionsUi`	166	170	+4

History

💔 Build #35684 failed ab671cf
💔 Build #35683 failed f71b13c
💔 Build #35679 failed bd29c61
💔 Build #35668 failed 76cc235
💔 Build #35661 failed 69b4b6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2022-04-02T14:49:00Z

💔 All backports failed

Status	Branch	Result
❌	8.2	Backport failed because of merge conflicts You might need to backport the following PRs to 8.2: - [RAM] Disable rule status dropdown on readonly user (#128971)

Manual backport

To create the backport manually run:

node scripts/backport --pr 128925

Questions ?

Please refer to the Backport tool documentation

* add error log on details page + snooze * refresh table in details page * fix type * add + fix jest test * add test for error log * remove console * update functional test + delete flaky jest test + fix i18n * review I * remove skip * review II * remove disable panel * clean up design * fix check * fix types * Design tweaks to header, status dropdown, mobile * remove dead code * jest test * fix actions layout * review III Co-authored-by: Ryan Keairns <contactryank@gmail.com> (cherry picked from commit d6b8e4b)

XavierM added 2 commits March 30, 2022 11:26

add error log on details page + snooze

da19ca4

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

d691af1

XavierM added bug Fixes for quality problems that affect the customer experience UX impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Mar 30, 2022

XavierM requested a review from a team as a code owner March 30, 2022 15:31

XavierM added v8.2.0 v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement labels Mar 30, 2022

XavierM added 2 commits March 30, 2022 14:56

refresh table in details page

00f49cb

fix type

9c74430

JiaweiWu mentioned this pull request Mar 30, 2022

[RAM} Add refine search prompt to rule execution log #128982

Merged

XavierM added 5 commits March 31, 2022 11:56

add + fix jest test

766d261

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

36949d7

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

a8a1939

add test for error log

055e1e7

remove console

4e9442f

JiaweiWu reviewed Mar 31, 2022

View reviewed changes

XavierM added 2 commits March 31, 2022 21:44

update functional test + delete flaky jest test + fix i18n

abeeecc

review I

74113f9

XavierM force-pushed the rule-error-logs branch from 75cf550 to 74113f9 Compare April 1, 2022 02:43

remove skip

740180a

ymao1 reviewed Apr 1, 2022

View reviewed changes

XavierM added 4 commits April 1, 2022 13:16

review II

fa7e451

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

776006c

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

2703231

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

1367fa5

remove disable panel

326d1d4

XavierM requested a review from a team as a code owner April 1, 2022 20:02

cchaos previously requested changes Apr 1, 2022

View reviewed changes

...ck/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule.scss Outdated Show resolved Hide resolved

JiaweiWu approved these changes Apr 1, 2022

View reviewed changes

cchaos mentioned this pull request Apr 1, 2022

[EuiEmptyPrompt] Is too tall with no easy way to customize elastic/eui#5755

Closed

clean up design

0a8559c

XavierM and others added 3 commits April 1, 2022 16:58

fix check

39f1a20

fix types

69b4b6b

Design tweaks to header, status dropdown, mobile

8676edd

XavierM added 5 commits April 1, 2022 17:58

remove dead code

76cc235

Merge pull request #10 from ryankeairns/rule-error-logs

9b5a393

Design tweaks to header, status dropdown, mobile

jest test

e751e57

Merge branch 'rule-error-logs' of github.com:XavierM/kibana into rule…

7072a06

…-error-logs

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

bd29c61

ymao1 approved these changes Apr 2, 2022

View reviewed changes

XavierM added 2 commits April 1, 2022 21:11

fix actions layout

f71b13c

review III

ab671cf

XavierM enabled auto-merge (squash) April 2, 2022 01:45

XavierM added 2 commits April 2, 2022 07:17

use mount instead fo shallow

8e70a4b

Merge branch 'main' of github.com:elastic/kibana into rule-error-logs

90d4cc6

XavierM merged commit d6b8e4b into elastic:main Apr 2, 2022

XavierM mentioned this pull request Apr 3, 2022

[8.2] [RAM] Add error logs in rule details page #129278

Merged

gmmorris mentioned this pull request Apr 11, 2022

[RAM] Rule summary refresh should also refresh execution logs #128812

Closed

Conversation

XavierM commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Mar 30, 2022

Uh oh!

JiaweiWu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JiaweiWu Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

XavierM Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JiaweiWu Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JiaweiWu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XavierM commented Apr 1, 2022

Uh oh!

ryankeairns commented Apr 1, 2022

Design PR

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented Apr 2, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

kibanamachine commented Apr 2, 2022

💔 All backports failed

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

XavierM commented Mar 30, 2022 •

edited

Loading

JiaweiWu left a comment •

edited

Loading