Skip to content

[Security solution][Session view] - Adding Session Viewer Icons#128828

Merged
opauloh merged 3 commits intoelastic:mainfrom
opauloh:session-view-icons
Mar 30, 2022
Merged

[Security solution][Session view] - Adding Session Viewer Icons#128828
opauloh merged 3 commits intoelastic:mainfrom
opauloh:session-view-icons

Conversation

@opauloh
Copy link
Contributor

@opauloh opauloh commented Mar 29, 2022

Summary

This PR makes use of new Icons that were introduced on EUI for the Session Viewer plugin

  • sessionViewer icon - Used to indicate that the session will be opened in Session Viewer, created a new Icon instead of using the console to enforce that it's a terminal Session Viewer
  • desktop icon: Used to indicate a Session being displayed on a monitor.
  • gear icon: Used to indicate a Non-Interactive Session.

Screenshot

Open in Session view in hosts page

image

Open in Session view in timeline

image

Session Viewer - Interactive Session

image

Session viewer - Non Interactive Session

image

@opauloh opauloh requested a review from a team March 29, 2022 21:28
@opauloh opauloh requested a review from a team as a code owner March 29, 2022 21:28
@opauloh opauloh added v8.2.0 backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes labels Mar 29, 2022
Copy link

@zizhouW zizhouW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@mitodrummer mitodrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelolo24
Copy link
Contributor

🎆 🚀

@michaelolo24
Copy link
Contributor

@elasticmachine merge upstream

@opauloh opauloh merged commit 66f4b12 into elastic:main Mar 30, 2022
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +6.0B
sessionView 51.8KB 51.7KB -6.0B
total -0.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 510 509 -1
uptime 56 49 -7
total -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @opauloh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants