Skip to content

[7.17] Fixed API Key Tests (#127236)#128510

Closed
kibanamachine wants to merge 2 commits into7.17from
backport/7.17/pr-127236
Closed

[7.17] Fixed API Key Tests (#127236)#128510
kibanamachine wants to merge 2 commits into7.17from
backport/7.17/pr-127236

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

* Added code to remove existing API keys before and after all tests.

* Fixed delete function.

* Fixing nits in PR.

* Fixed test.

* Removed await keywords per nits and broke out clearAllApiKeys() to a helper file.

* Added types for typescript

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b887d38)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Mar 24, 2022
@kibanamachine kibanamachine enabled auto-merge (squash) March 24, 2022 16:18
@LeeDr
Copy link
Copy Markdown

LeeDr commented Mar 28, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 28, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cuff-links

@cuff-links
Copy link
Copy Markdown
Contributor

We are skipping port to 7.17. #128930 I thought we closed this in 128930, but I guess there were 2 backports for the same version.

@cuff-links cuff-links closed this Apr 12, 2022
auto-merge was automatically disabled April 12, 2022 01:18

Pull request was closed

@spalger spalger deleted the backport/7.17/pr-127236 branch May 8, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants