Skip to content

[App Search] Filter Elasticsearch index based engines from meta engine creation#128503

Merged
efegurkan merged 2 commits intoelastic:mainfrom
efegurkan:fix-meta-engines-allowing-es-engines
Mar 24, 2022
Merged

[App Search] Filter Elasticsearch index based engines from meta engine creation#128503
efegurkan merged 2 commits intoelastic:mainfrom
efegurkan:fix-meta-engines-allowing-es-engines

Conversation

@efegurkan
Copy link
Copy Markdown
Member

Fixes https://github.com/elastic/enterprise-search-team/issues/1686

Summary

This filters out Elasticsearch indices based engines to show up on the meta engine creation views.

Screen.Recording.2022-03-24.at.15.46.45.mov

Checklist

Delete any items that are not applicable to this PR.

@efegurkan efegurkan added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.2.0 Team:EnterpriseSearch labels Mar 24, 2022
@efegurkan efegurkan requested a review from a team March 24, 2022 14:50
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB +91.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@efegurkan efegurkan merged commit 5e847ac into elastic:main Mar 24, 2022
@efegurkan efegurkan deleted the fix-meta-engines-allowing-es-engines branch March 24, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants