Skip to content

[maps] clarify how layer filters are applied to term joins#128502

Merged
nreese merged 7 commits intoelastic:mainfrom
nreese:layer_filter_doc
Mar 31, 2022
Merged

[maps] clarify how layer filters are applied to term joins#128502
nreese merged 7 commits intoelastic:mainfrom
nreese:layer_filter_doc

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Mar 24, 2022

The existing wording of https://www.elastic.co/guide/en/kibana/current/maps-layer-based-filtering.html is vague and does not clearly explain how layer based filters are applied to layers with term joins. This PR adds some clarifying text and an example.

@nreese nreese added Team:Docs Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v8.1.0 v7.17.0 v8.2.0 labels Mar 24, 2022
@nreese nreese requested a review from gchaps March 24, 2022 14:43
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 24, 2022
@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 30, 2022

@elasticmachine merge upstream

@nreese nreese added the v8.3.0 label Mar 30, 2022
Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 093d649 into elastic:main Mar 31, 2022
kibanamachine added a commit that referenced this pull request Mar 31, 2022
* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)
kibanamachine added a commit that referenced this pull request Mar 31, 2022
* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)
kibanamachine added a commit that referenced this pull request Mar 31, 2022
* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)
kibanamachine added a commit that referenced this pull request Mar 31, 2022
* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.0
8.1
7.17
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 31, 2022
…129132)

* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Mar 31, 2022
…129135)

* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Mar 31, 2022
…129134)

* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Mar 31, 2022
…129133)

* [maps] clarify how layer filters are applied to term joins

* typo

* clean up

* change to present tense

* fix typo

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
(cherry picked from commit 093d649)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.17.0 v8.0.0 v8.1.0 v8.2.0 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants