[Fleet] Merge settings & mappings component template in @package#128498
[Fleet] Merge settings & mappings component template in @package#128498nchaulet merged 7 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
|
I'm +1 on this change, but I'd like to do some extra testing on this before we merge. @hop-dev let's make sure we update the test instructions for the QA team on the mappings component issue. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
|
What is the migration path from old to new? At what stage will the change be applied? |
This change will be applied when a package is upgraded or reinstalled. @hop-dev I think you make a change to do |
Yes thats right, it will be applied to every package on kibana startup |
If a package is reinstalled, does it mean all data streams are rolled over or only the ones with a conflict? |
Only one with conflict otherwise we just update the backing indices. |
joshdover
left a comment
There was a problem hiding this comment.
LGTM, did additional testing upgrading from 8.1 -> this branch and found no unexpected issues. My custom mappings in @custom templates were correctly applied after the upgrade.
Summary
Resolve #128209
Mappings could depend on some other fields defined in template settings like analyzer for example. To avoid issues with missing settings, that PR merge
@mappingsand@settingscomponent template in a new@packagecomponent template that contains both index template mapping and settings.