Skip to content

[Security solution][Session view] Separate alerts from events in Process#128434

Merged
zizhouW merged 2 commits intoelastic:mainfrom
zizhouW:separate-events-alerts-session-view
Mar 24, 2022
Merged

[Security solution][Session view] Separate alerts from events in Process#128434
zizhouW merged 2 commits intoelastic:mainfrom
zizhouW:separate-events-alerts-session-view

Conversation

@zizhouW
Copy link
Copy Markdown

@zizhouW zizhouW commented Mar 23, 2022

follow up PR to #127991

  • Add tests for alert_status_route and use AlertsClient
  • Separate events and alerts for process

@zizhouW zizhouW added release_note:enhancement backport:skip This PR does not require backporting v8.2.0 Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution labels Mar 23, 2022
@zizhouW zizhouW linked an issue Mar 23, 2022 that may be closed by this pull request
[Meta Task] SessionView use callback passed from SecuitySolution to open alerts flyout. #128170
Closed
@zizhouW zizhouW requested review from Tacklebox, animehart, michaelolo24, mitodrummer and opauloh and removed request for michaelolo24 March 23, 2022 21:38
@zizhouW
Copy link
Copy Markdown
Author

zizhouW commented Mar 23, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 24, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sessionView 48.1KB 48.1KB +60.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mitodrummer
mitodrummer approved these changes Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mitodrummer mitodrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zizhouW zizhouW merged commit e95b064 into elastic:main Mar 24, 2022
@zizhouW zizhouW added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opauloh opauloh Awaiting requested review from opauloh

@animehart animehart Awaiting requested review from animehart

@Tacklebox Tacklebox Awaiting requested review from Tacklebox

1 more reviewer

@mitodrummer mitodrummer mitodrummer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Meta Task] SessionView use callback passed from SecuitySolution to open alerts flyout.

4 participants

@zizhouW @kibana-ci @mitodrummer @kibanamachine