[Lens] drag and drop functionality for annotations#128432
Merged
mbondyra merged 6 commits intoelastic:mainfrom Mar 24, 2022
Merged
[Lens] drag and drop functionality for annotations#128432mbondyra merged 6 commits intoelastic:mainfrom
mbondyra merged 6 commits intoelastic:mainfrom
Conversation
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/annotation_dnd
branch
from
c10b0b2 to
3792966
Compare
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
force-pushed
the
lens/annotation_dnd
branch
from
043ebd5 to
2202f5e
Compare
drewdaemon
approved these changes
Mar 24, 2022
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Code LGTM. Might be helpful to track the refactor in a follow-up tech-debt issue.
Contributor
Author
|
Thank you Andrew! Issue added: #128506 |
flash1293
approved these changes
Mar 24, 2022
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
LGTM, tested and works like a charm!
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements reorder & duplicating dimension in the group for annotations.
This is a code that will be immediately refactored in the next iteration but I want to squeeze it in for 8.2.
As always, dropping to empty button duplicates the dimension.
Reordering doesn't influence visualization in almost no way, except for the order in the tooltips if the annotations share the same exact timestamp. (see picture)
Mar-24-2022.14-23-53.mp4
I've also fixed a little issue- tooltip's times are now sorted:
before the position in the tooltip depended on position in annotations[] array.
Now it depends on timestamp (first go first) and then on the position in the array.
