[Security Solution][Detections] Adds a back button to the Tour UI on the Rule Management page#128405
Conversation
3e8e952 to
b00c65e
Compare
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @banderror |
spong
left a comment
There was a problem hiding this comment.
LGTM!
Two notes:
- Seems to be some jitter in the initial position. Not sure if this is new behavior or pre-existing, but this can be seen when clicking
Go backor when losing/regaining focus when on the first step.
Go back from step 2:
Focus change:
- This is more of component feedback about the EUITour, but it would be nice if there were left/right chevrons next to the tour step indicators that we could use for going forward/backward instead of having to plumb this ourselves. Would also be nice if the step indicator could be clicked too, but minor details. I know they're iterating fast on this component now as it's getting more use, so just some feedback we can provide the EUI folks.
|
@spong thank you, completely agree!
It's a pre-existing behavior. There's an issue elastic/eui#5731 that might be related. The suggestion is elastic/eui#5731 (comment). I think next time we decide to show a tour, we should try to use this new
++ There are two existing issues in the EUI repo about this, I posted some comments there: elastic/eui#4831 and elastic/eui#5715
It looks like they addressed #124052 in elastic/eui#5696 which would be fantastic! All in all, I think when we revisit the Tour UI, we should build it differently - using the new |



Ticket: #126084
Summary
This PR adds a back button to each of the two Tour steps. Users will be able to freely navigate between the steps.
Before
After