[Actionable Observability] filter by o11y rule types#128370
[Actionable Observability] filter by o11y rule types#128370mgiota merged 7 commits intoelastic:mainfrom
Conversation
a7ecd07 to
52bf722
Compare
c409f4b to
adf271a
Compare
|
@elasticmachine merge upstream |
|
@elastic/unified-observability Could somebody look into this please? We aim to get it in for 8.2 |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @mgiota |
afgomez
left a comment
There was a problem hiding this comment.
I'm not excited about adding something else to usePluginContext but for now it's OK.
I added a tiny comment. If no changes are necessary in that feel free to merge.
| onChange(selectedValues); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [selectedValues]); |
There was a problem hiding this comment.
what's the reason to skip the onChange from the dependency list?
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Fixes #127012
Notes for the reviewer
const { ObservabilityPageTemplate, kibanaFeatures } = usePluginContext();Let me know if you have a better recommendation or if it is fine the way I did it.
Screen.Recording.2022-03-23.at.14.59.48.mov