Skip to content

Deprecate QuickButtonGroup for IconButtonGroup in shared ux#128288

Merged
rshen91 merged 7 commits intoelastic:mainfrom
rshen91:deprecate-quick-button-group
Mar 24, 2022
Merged

Deprecate QuickButtonGroup for IconButtonGroup in shared ux#128288
rshen91 merged 7 commits intoelastic:mainfrom
rshen91:deprecate-quick-button-group

Conversation

@rshen91
Copy link
Copy Markdown
Contributor

@rshen91 rshen91 commented Mar 22, 2022 •
edited
Loading

Summary

This PR is an initial step to deprecate the QuickButtonGroup and replace with the refactored IconButtonGroup. Deprecation markers are added where appropriate the team can refactor in future PRs. Thanks!

@rshen91 rshen91 self-assigned this Mar 22, 2022
@rshen91 rshen91 added v8.2.0 Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// release_note:skip Skip the PR/issue when compiling release notes labels Mar 22, 2022
@rshen91 rshen91 marked this pull request as ready for review March 23, 2022 14:40
@rshen91 rshen91 requested a review from a team as a code owner March 23, 2022 14:40
ThomThomson
ThomThomson approved these changes Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation LGTM! Are there any functional or appearance changes in the new IconButtonGroup? Or is it the same component moved?

If it is the same component, I wonder if it would be possible to replace the instances of it from presentation_util with the new component in the same PR - just so we don't have to double up!

If not, no worries!

@rshen91 rshen91 enabled auto-merge (squash) March 24, 2022 17:26
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 24, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit 83117a4 into elastic:main Mar 24, 2022
@rshen91 rshen91 deleted the deprecate-quick-button-group branch March 24, 2022 19:13
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128288 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 28, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128288 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 30, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128288 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This PR does not require backporting label Mar 30, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@rshen91 rshen91

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rshen91 @kibana-ci @kibanamachine @ThomThomson @spalger