[RAM] Add aggs to know how many rules are snoozed#128212
[RAM] Add aggs to know how many rules are snoozed#128212XavierM merged 12 commits intoelastic:mainfrom
Conversation
| />, | ||
| <EuiStat | ||
| title={ruleStats.muted} | ||
| title={ruleStats.muted + ruleStats.snoozed} |
There was a problem hiding this comment.
@XavierM I would like to see this PR merged #128108 where we implemented the snoozed status (and update the muteAll field) and do a bit of manual testing to see if these numbers work well.
I am just writing the scenarios I would like to test once both PRs are merged:
Scenario 1
- User in Stack Management selects snooze for a specified timerange for one rule. (The muteAll field I guess will be false in this case, right?)
- In o11y rules page status for this rule will appear as enabled and not snoozed permanently
- In Alerts page there will be 1 Snoozed alert
Scenario 2
- User in Stack Management selects snooze for a specified timerange for one rule.
- In o11y rules page status for this rule will appear as enabled
- In o11y rules page user selects Snoozed permanently for another rule
- In Alerts page there will be 2 Snoozed alerts (the one from stack Management ruleStats.snoozed and the other from o11y rules page ruleStats.muted)
| <EuiStat | ||
| title={ruleStats.muted} | ||
| title={ruleStats.muted + ruleStats.snoozed} | ||
| description={i18n.translate('xpack.observability.alerts.ruleStats.muted', { |
There was a problem hiding this comment.
@XavierM Shall we make it explicit in the name that it contains muted and snoozed xpack.observability.alerts.ruleStats.mutedAndSnoozed?
There was a problem hiding this comment.
I don't mind keeping it as it is either.
There was a problem hiding this comment.
let's keep it like that for now because this is going to change again in the next release meaning muted will become deprecated sooner than later.
|
Pinging @elastic/response-ops (Team:ResponseOps) |
chrisronline
left a comment
There was a problem hiding this comment.
First pass, and looking good!
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Add aggregation to know how may rules are snoozed, this will allow us to resolve #126498
Checklist