Skip to content

[Lens] fix loosing tables in activeData#127851

Merged
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:lens/fix_active_data
Mar 16, 2022
Merged

[Lens] fix loosing tables in activeData#127851
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:lens/fix_active_data

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented Mar 16, 2022 •
edited
Loading

Summary

When new activeData is coming, it only contains last layer. Introduced minutes ago: #126786

@mbondyra mbondyra added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.2.0 labels Mar 16, 2022
@mbondyra mbondyra requested a review from a team as a code owner March 16, 2022 08:56
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 16, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra mbondyra changed the title [Lens] fix loosing the datatables in activeData [Lens] fix loosing tables in activeData Mar 16, 2022
dej611
dej611 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review only 👍

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 16, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit d06f6ad into elastic:main Mar 16, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@mbondyra @maksimkovalev
[Lens] fix loosing tables in activeData (elastic#127851)
18c865e 
* [Lens] fix loosing the datatables in activeData

* added test for two tables
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 18, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127851 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022
@stratoula stratoula added the backport:skip This PR does not require backporting label Mar 18, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dej611 dej611 dej611 approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mbondyra @elasticmachine @kibana-ci @kibanamachine @dej611 @alexwizp @stratoula