Skip to content

[Upgrade Assistant] Fix broken test that is missing HttpSetup instance in setup method#127779

Closed
sabarasaba wants to merge 1 commit intoelastic:mainfrom
sabarasaba:ua/fix_broken_test
Closed

[Upgrade Assistant] Fix broken test that is missing HttpSetup instance in setup method#127779
sabarasaba wants to merge 1 commit intoelastic:mainfrom
sabarasaba:ua/fix_broken_test

Conversation

@sabarasaba
Copy link
Member

Fixes: #127722

With #127122 there might have been a small merge conflict that was wrongly unresolved from #126693. This PR fixes that by providing the correct HttpSetup instance to the setupOverviewPage method.

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v7.17.2 labels Mar 15, 2022
@sabarasaba sabarasaba self-assigned this Mar 15, 2022
@jbudz
Copy link
Contributor

jbudz commented Mar 15, 2022

@sabarasaba FYI I just pushed a revert up for #127122 to get CI green. Would you mind updating the branch and reverting 7b86f00 to test the changes?

@jbudz
Copy link
Contributor

jbudz commented Mar 15, 2022

cc @azasypkin

@kibana-ci
Copy link

kibana-ci commented Mar 15, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled create_threat_matching tests with auditbeat data indicator enrichment adds a single indicator that matched multiple fields
  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled create_threat_matching tests with auditbeat data indicator enrichment adds a single indicator that matched multiple fields

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 15 +1

ESLint disabled line counts

id before after diff
apm 85 88 +3

References to deprecated APIs

id before after diff
upgradeAssistant 3 8 +5

Total ESLint disabled count

id before after diff
apm 99 103 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba
Copy link
Member Author

Closing in favour of #127784

@sabarasaba sabarasaba closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.17.2 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/logs_step - Overview - Logs Step error state is rendered

3 participants