[Upgrade Assistant] Fix broken test that is missing HttpSetup instance in setup method#127779
Closed
sabarasaba wants to merge 1 commit intoelastic:mainfrom
Closed
[Upgrade Assistant] Fix broken test that is missing HttpSetup instance in setup method#127779sabarasaba wants to merge 1 commit intoelastic:mainfrom
sabarasaba wants to merge 1 commit intoelastic:mainfrom
Conversation
Contributor
|
@sabarasaba FYI I just pushed a revert up for #127122 to get CI green. Would you mind updating the branch and reverting 7b86f00 to test the changes? |
Contributor
|
cc @azasypkin |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: cc @sabarasaba |
Member
Author
|
Closing in favour of #127784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #127722
With #127122 there might have been a small merge conflict that was wrongly unresolved from #126693. This PR fixes that by providing the correct
HttpSetupinstance to thesetupOverviewPagemethod.