Skip to content

Uses SavedObjectsClient for UI Settings#12747

Merged
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:ui-settings-saved-objects
Jul 11, 2017
Merged

Uses SavedObjectsClient for UI Settings#12747
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:ui-settings-saved-objects

Conversation

@tylersmalley
Copy link
Member

No description provided.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the ui-settings-saved-objects branch from 1d3517b to ebdb4d9 Compare July 11, 2017 04:53
@tylersmalley tylersmalley requested a review from spalger July 11, 2017 05:29
@spalger
Copy link
Contributor

spalger commented Jul 11, 2017

This is great, but before we can require a SavedObjectsClient when creating a uiSettingsService we need to add a way to instantiate a SavedObjectsClient using a server factory like https://github.com/elastic/kibana/blob/master/src/ui/ui_settings/ui_settings_mixin.js#L40

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests pass

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed something, thinking there might be an issue with removing the ignore401Errors handling...

@spalger spalger force-pushed the ui-settings-saved-objects branch from ef08852 to a4909dc Compare July 11, 2017 16:11
@tylersmalley tylersmalley merged commit 44dedd6 into elastic:master Jul 11, 2017
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jul 11, 2017
@tylersmalley
Copy link
Member Author

tylersmalley commented Jul 11, 2017

5.x: 1cd2597

@epixa
Copy link
Contributor

epixa commented Jul 11, 2017

@tylersmalley I think that backport belongs to a different PR, no?

@tylersmalley
Copy link
Member Author

@epixa, you're right - updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants