Skip to content

Fixed API Key Tests #127236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuff-links merged 13 commits into from
Mar 24, 2022
Merged

Fixed API Key Tests #127236

Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0e7def9
Added code to remove existing API keys before and after all tests.
cuff-links Mar 9, 2022
aafdf2d
Merge branch 'main' into Fix_API_Keys_Test
kibanamachine Mar 9, 2022
e6e6538
Fixed delete function.
Mar 17, 2022
4a9e91d
Merge branch 'Fix_API_Keys_Test' of github.com:cuff-links/kibana into…
Mar 17, 2022
0c77afc
Merge branch 'main' into Fix_API_Keys_Test
kibanamachine Mar 17, 2022
00bc06d
Merge branch 'main' into Fix_API_Keys_Test
kibanamachine Mar 17, 2022
39e5459
Merge branch 'main' into Fix_API_Keys_Test
kibanamachine Mar 21, 2022
8877bc4
Fixing nits in PR.
Mar 21, 2022
4763b51
Merge branch 'Fix_API_Keys_Test' of github.com:cuff-links/kibana into…
Mar 21, 2022
2370e07
Fixed test.
Mar 22, 2022
c5d44ee
Removed await keywords per nits and broke out clearAllApiKeys() to a …
Mar 22, 2022
9f9afbd
Added types for typescript
Mar 22, 2022
217f6a6
Merge branch 'main' of github.com:elastic/kibana into Fix_API_Keys_Test
Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions x-pack/test/functional/apps/api_keys/home_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,26 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const log = getService('log');
const security = getService('security');
const testSubjects = getService('testSubjects');
const es = getService('es');
const find = getService('find');
const browser = getService('browser');

async function clearAllApiKeys() {
const existingKeys = await es.security.queryApiKeys();
if (existingKeys.count > 0) {
Promise.all(
await existingKeys.api_keys.map(async (key) => {
Comment thread
cuff-links marked this conversation as resolved.
Outdated
await es.security.invalidateApiKey({ ids: [key.id] });
Comment thread
cuff-links marked this conversation as resolved.
Outdated
})
);
} else {
log.debug('No API keys to delete.');
}
}

describe('Home page', function () {
before(async () => {
await clearAllApiKeys();
Comment thread
cuff-links marked this conversation as resolved.
Outdated
await security.testUser.setRoles(['kibana_admin']);
await pageObjects.common.navigateToApp('apiKeys');
});
Expand All @@ -39,8 +54,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('creates API key', function () {
before(async () => {
await security.testUser.setRoles(['kibana_admin']);
await security.testUser.setRoles(['test_api_keys']);
await security.testUser.setRoles(['kibana_admin', 'test_api_keys']);
await pageObjects.common.navigateToApp('apiKeys');

// Delete any API keys created outside of these tests
Expand All @@ -51,6 +65,10 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await pageObjects.apiKeys.deleteAllApiKeyOneByOne();
});

after(async () => {
await clearAllApiKeys();
Comment thread
cuff-links marked this conversation as resolved.
Outdated
});

it('when submitting form, close dialog and displays new api key', async () => {
const apiKeyName = 'Happy API Key';
await pageObjects.apiKeys.clickOnPromptCreateApiKey();
Expand Down Expand Up @@ -95,8 +113,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('deletes API key(s)', function () {
before(async () => {
await security.testUser.setRoles(['kibana_admin']);
await security.testUser.setRoles(['test_api_keys']);
await security.testUser.setRoles(['kibana_admin', 'test_api_keys']);
await pageObjects.common.navigateToApp('apiKeys');
});

Expand Down