[Fleet] Fix ES error during filtering on agent status#127234
Merged
jen-huang merged 5 commits intoelastic:mainfrom Mar 9, 2022
Merged
[Fleet] Fix ES error during filtering on agent status#127234jen-huang merged 5 commits intoelastic:mainfrom
jen-huang merged 5 commits intoelastic:mainfrom
Conversation
… integer only, remove expect error annotations
jen-huang
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jen-huang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #127110
This PR fixes an ES error being returned when filtering list of agents by status. This is a regression from #124488 where some default ES client parameters were changed, thereby causing
bodyto no longer be present in the response keys (i.e.res.body.hits->res.hits).Most occurrences were caught & fixed during that PR, but a few were missed due to the lines having
@ts-expect-errorerror suppression annotations. This PR removes these annotations by 1) sendingrest_total_hits_as_intso that total hits is always returned as a integer, rather than an object and 2) asserting to the compiler thathits.totalis indeed anumber. If the structure of ES search response changes again in the future, type errors should bubble up.