Skip to content

unskipping a11y painless lab test #127082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2022
Merged

unskipping a11y painless lab test #127082

merged 7 commits into from
Mar 10, 2022

Conversation

@rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Mar 7, 2022

@rashmivkulkarni rashmivkulkarni added Project:Accessibility test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Painless Lab Dev tool for learning Painless auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 v8.2.0 labels Mar 7, 2022
@rashmivkulkarni rashmivkulkarni self-assigned this Mar 7, 2022
@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Mar 9, 2022

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Mar 9, 2022

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/241 flaky test runner

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Mar 9, 2022

https://ci-stats.kibana.dev/trigger_flaky_test_runner/3

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Mar 9, 2022

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/250

@kibana-ci
Copy link

kibana-ci commented Mar 10, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
painlessLab 16.2KB 16.2KB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review March 10, 2022 03:55
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner March 10, 2022 03:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 10, 2022

Pinging @elastic/kibana-accessibility (Project:Accessibility)

sabarasaba
sabarasaba approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching these up @rashmivkulkarni! Changes lgtm

@sabarasaba
Copy link
Member

sabarasaba commented Mar 10, 2022

Though I dont think we'd want to merge this for 7.17 and for 8.0.0 since they are past FF.

bhavyarm
bhavyarm approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LeeDr
LeeDr approved these changes Mar 10, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - at some point we should look into a11y.testAppSnapshot() and see if it should do a retry or if we should pass some args to make it retry

@rashmivkulkarni rashmivkulkarni merged commit 1493348 into elastic:main Mar 10, 2022
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@rashmivkulkarni @kibanamachine
unskipping a11y painless lab test (#127082)
718254d 
* unskipping a11y painless lab test

* focusable element

* adding an extra step to get the element in focus

* changes to make it work

* introduce an retry loop

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 1493348)
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Merged
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@rashmivkulkarni @kibanamachine
unskipping a11y painless lab test (#127082)
d341a05 
* unskipping a11y painless lab test

* focusable element

* adding an extra step to get the element in focus

* changes to make it work

* introduce an retry loop

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 1493348)
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Closed
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@rashmivkulkarni @kibanamachine
unskipping a11y painless lab test (#127082)
33a2afe 
* unskipping a11y painless lab test

* focusable element

* adding an extra step to get the element in focus

* changes to make it work

* introduce an retry loop

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 1493348)
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 10, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 7.17
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Mar 10, 2022
Merged
Merged
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@kibanamachine @rashmivkulkarni
unskipping a11y painless lab test (#127082) (#127475)
3e3bfc6 
* unskipping a11y painless lab test

* focusable element

* adding an extra step to get the element in focus

* changes to make it work

* introduce an retry loop

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 1493348)

Co-authored-by: Rashmi Kulkarni <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2022
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 14, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@rashmivkulkarni rashmivkulkarni removed v7.17.2 v8.0.2 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 14, 2022
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 15, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2022
@rashmivkulkarni rashmivkulkarni removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 15, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 16, 2022
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 16, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@cjcenizal cjcenizal added the backport:skip This PR does not require backporting label Mar 17, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 17, 2022
@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Apr 15, 2022

this test is still skipped on 7.17.3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@bhavyarm bhavyarm bhavyarm approved these changes

+1 more reviewer

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rashmivkulkarni rashmivkulkarni

Labels

backport:skip This PR does not require backporting Feature:Painless Lab Dev tool for learning Painless Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.1.1 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rashmivkulkarni @kibana-ci @elasticmachine @sabarasaba @kibanamachine @bhavyarm @LeeDr @cjcenizal