Skip to content

[Security Solutions] Small telemetry fixes#126831

Merged
FrankHassanabad merged 2 commits intoelastic:mainfrom
FrankHassanabad:small-fixes
Mar 3, 2022
Merged

[Security Solutions] Small telemetry fixes#126831
FrankHassanabad merged 2 commits intoelastic:mainfrom
FrankHassanabad:small-fixes

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

@FrankHassanabad FrankHassanabad commented Mar 3, 2022

Summary

Small fixes and just a few docs to clarify things. I might be wrong on what I'm doing, so please let me know.

Looking at the telemetry data from servers I see things like this (I made this up, not real data, but the shape of the data is the same as what we see on the servers):

"securitySolution:overview" : {
  "clicks_total" : 420,
  "minutes_on_screen_total" : 55.58454999999998,
  "viewId" : "main",
  "clicks_7_days" : 0,
  "clicks_90_days" : 0,
  "appId" : "securitySolution:overview",
  "minutes_on_screen_7_days" : 0,
  "minutes_on_screen_30_days" : 0,
  "clicks_30_days" : 0,
  "minutes_on_screen_90_days" : 0
},

and I also see the views which is 👍 what I would make the dashboards from ... So not for sure if the structure above this is legacy. I could not get the shape of data above to happen locally. However, this shape below seems better and what I would create dashboards from.

"securitySolution" : {
  "clicks_total" : 420,
  "minutes_on_screen_total" : 2.90670000000006,
  "viewId" : "main",
  "clicks_7_days" : 70,
  "clicks_90_days" : 370,
  "appId" : "securitySolution",
  "minutes_on_screen_7_days" : 104.62756666666667,
  "minutes_on_screen_30_days" : 121.61288333333334,
  "clicks_30_days" : 121,
  "minutes_on_screen_90_days" : 250.55426666666665,
  "views" : [
    {
      "clicks_total" : 8,
      "minutes_on_screen_total" : 5.709183333333334,
      "viewId" : "overview",
      "clicks_7_days" : 0,
      "clicks_90_days" : 6,
      "appId" : "securitySolution",
      "minutes_on_screen_7_days" : 0,
      "minutes_on_screen_30_days" : 0.5038833333333333,
      "clicks_30_days" : 0,
      "minutes_on_screen_90_days" : 6.565383333333333
    },

With this new key of "securitySolutionUI" I don't see keys like securitySolutionUI:overview but I do see the views like above so let me know if changing the keys here in some areas are a mistake or not or if this is not the right thing to do.

Ref to earlier PR with the new key of securitySolutionUI from APP_ID changing:
#113573

@FrankHassanabad FrankHassanabad requested review from a team as code owners March 3, 2022 18:20
@FrankHassanabad FrankHassanabad self-assigned this Mar 3, 2022
@FrankHassanabad FrankHassanabad added v8.2.0 release_note:skip Skip the PR/issue when compiling release notes Team:Security Solution Platform labels Mar 3, 2022
Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change @FrankHassanabad

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit 9c45883 into elastic:main Mar 3, 2022
@FrankHassanabad FrankHassanabad deleted the small-fixes branch March 3, 2022 20:00
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 7, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126831 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126831 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126831 or prevent reminders by adding the backport:skip label.

@FrankHassanabad FrankHassanabad added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 10, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 126831

Questions ?

Please refer to the Backport tool documentation

@FrankHassanabad FrankHassanabad added backport:skip This PR does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants