[ToolingLog] remove some manual indent management#126636
Merged
spalger merged 4 commits intoelastic:mainfrom Mar 3, 2022
Merged
[ToolingLog] remove some manual indent management#126636spalger merged 4 commits intoelastic:mainfrom
spalger merged 4 commits intoelastic:mainfrom
Conversation
spalger
force-pushed
the
remove/some-manual-log-intent-management
branch
from
a9afb8b to
620812f
Compare
spalger
force-pushed
the
remove/some-manual-log-intent-management
branch
from
620812f to
3d15a81
Compare
spalger
added
auto-backport
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Mar 2, 2022
afharo
approved these changes
Mar 3, 2022
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
LGTM! I noticed we are removing the indentation and one log from src/core/test_helpers/kbn_server.ts, but I see where you're coming from. All good on my end.
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
* [ToolingLog] remove some manual indent management * improve log message * [dev/build] write the newline after a failed step Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4f2321d)
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
* [ToolingLog] remove some manual indent management * improve log message * [dev/build] write the newline after a failed step Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4f2321d)
Contributor
💔 Some backports could not be created
Manual backportTo create the backport manually run: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 3, 2022
* [ToolingLog] remove some manual indent management * improve log message * [dev/build] write the newline after a failed step Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4f2321d) # Conflicts: # packages/kbn-es/src/cluster.js
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
* [ToolingLog] remove some manual indent management * improve log message * [dev/build] write the newline after a failed step Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4f2321d) Co-authored-by: Spencer <spencer@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
* [ToolingLog] remove some manual indent management * improve log message * [dev/build] write the newline after a failed step Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4f2321d) Co-authored-by: Spencer <spencer@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is some indentation level missmatching happening in our logging output, so rather than using manual indent incrementing/decrementing we should try to use the
blockversion ofindent()as often as feasible. This waits for the block to complete or fail and then resets the log level to where it was before the block started.