Skip to content

[Telemetry] Move privacy statement URL to doc links#126597

Merged
gsoldevila merged 32 commits intoelastic:mainfrom
gsoldevila:kbn-99767-privacy-statement-to-doc-links
Mar 18, 2022
Merged

[Telemetry] Move privacy statement URL to doc links#126597
gsoldevila merged 32 commits intoelastic:mainfrom
gsoldevila:kbn-99767-privacy-statement-to-doc-links

Conversation

@gsoldevila
Copy link
Copy Markdown
Member

@gsoldevila gsoldevila commented Mar 1, 2022 •
edited
Loading

Summary

Closes #99767

  • Move the privacy statement URL to the docLinks service. This URL is currently stored in a constant defined within the telemetry plugin.
  • Fix a typo present in a bunch of files: dockLinks ➡ docLinks.
  • Use the opportunity to improve a bunch of CoreSetup['xxx'] ➡ XxxSetup and CoreStart['xxx'] ➡ XxxStart imports.

@gsoldevila gsoldevila requested review from a team as code owners March 1, 2022 14:28
@gsoldevila gsoldevila added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Mar 1, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 1, 2022

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 1, 2022
afharo
afharo reviewed Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR! I added a couple of NITs. Please, take a look at the broken tests. Let me know if you need any help with those.

lcawl
lcawl approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the link in the service LGTM

@gsoldevila gsoldevila requested review from a team as code owners March 2, 2022 17:50
@gsoldevila gsoldevila requested a review from a team March 2, 2022 17:50
@gsoldevila gsoldevila requested review from a team as code owners March 2, 2022 17:50
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 2, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 2, 2022

Pinging @elastic/apm-ui (Team:apm)

@gsoldevila
Copy link
Copy Markdown
Member Author

gsoldevila commented Mar 2, 2022

@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward! Presentation team changes LGTM

jportner
jportner approved these changes Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM

miltonhultgren
miltonhultgren approved these changes Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type changes in Monitoring look fine 👍🏼

shahzad31
shahzad31 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

darnautov
darnautov approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transform changes LGTM

Dosant
Dosant approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app services src/data lgtm

gbamparop
gbamparop approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

@gsoldevila gsoldevila added the backport:skip This PR does not require backporting label Mar 16, 2022
@gsoldevila gsoldevila enabled auto-merge (squash) March 16, 2022 16:13
@gsoldevila gsoldevila disabled auto-merge March 17, 2022 09:34
@gsoldevila gsoldevila enabled auto-merge (squash) March 17, 2022 10:06
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 18, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/doc-links 62 63 +1
telemetry 0 1 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 40.6KB 40.6KB -6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 295.8KB 295.9KB +55.0B
telemetry 27.2KB 27.5KB +385.0B
telemetryManagementSection 9.8KB 9.8KB -39.0B
total +401.0B
Unknown metric groups

API count

id before after diff
@kbn/doc-links 62 63 +1
telemetry 41 43 +2
total +3

ESLint disabled line counts

id before after diff
telemetry 8 1 -7

Total ESLint disabled count

id before after diff
telemetry 14 7 -7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila
Copy link
Copy Markdown
Member Author

gsoldevila commented Mar 18, 2022

Ping @elastic/platform-deployment-management could you please review? Thanks in advance

@gsoldevila gsoldevila merged commit 649fc1f into elastic:main Mar 18, 2022
@gsoldevila gsoldevila self-assigned this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@darnautov darnautov darnautov approved these changes

@afharo afharo afharo approved these changes

@gbamparop gbamparop gbamparop approved these changes

@Dosant Dosant Dosant approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@lcawl lcawl lcawl approved these changes

+3 more reviewers

@majagrubic majagrubic majagrubic approved these changes

@sebelga sebelga sebelga approved these changes

@jportner jportner jportner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsoldevila gsoldevila

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Telemetry] Use DocLinks for the Privacy Statement link