Skip to content

[Discover] Fix "encoded URL params in context page" cloud test permissions#126470

Merged
dimaanj merged 5 commits intoelastic:mainfrom
dimaanj:fix-cloud-test-for-encoded-param-in-context
Mar 15, 2022
Merged

[Discover] Fix "encoded URL params in context page" cloud test permissions#126470
dimaanj merged 5 commits intoelastic:mainfrom
dimaanj:fix-cloud-test-for-encoded-param-in-context

Conversation

@dimaanj
Copy link
Copy Markdown
Contributor

@dimaanj dimaanj commented Feb 28, 2022 •
edited
Loading

Summary

Fixes #124432

Fixes "encoded URL params in context page" cloud functional test by adding right permissions.

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.2.0 labels Feb 28, 2022
@dimaanj dimaanj self-assigned this Feb 28, 2022
@kertal
Copy link
Copy Markdown
Member

kertal commented Mar 2, 2022

Dear @liza-mae, could you verify if this works now, many thx

@liza-mae liza-mae self-requested a review March 4, 2022 19:14
liza-mae
liza-mae suggested changes Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertal asked me to run these against cloud. It is missing setting the role to the test user to view the context_encoded_param.

@dimaanj dimaanj requested a review from liza-mae March 14, 2022 11:52
liza-mae
liza-mae approved these changes Mar 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimaanj dimaanj marked this pull request as ready for review March 14, 2022 16:55
@dimaanj dimaanj requested a review from a team as a code owner March 14, 2022 16:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 14, 2022

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Copy Markdown
Contributor Author

dimaanj commented Mar 14, 2022

@elasticmachine merge upstream

kertal
kertal approved these changes Mar 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged when CI turns green

@kertal
Copy link
Copy Markdown
Member

kertal commented Mar 14, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 14, 2022

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #15 / machine learning data visualizer data view management adds new field

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj merged commit 5533748 into elastic:main Mar 15, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 17, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126470 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 17, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 18, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126470 or prevent reminders by adding the backport:skip label.

maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@dimaanj @kibanamachine @maksimkovalev
[Discover] Fix "encoded URL params in context page" cloud test permis…
17c12ac 
…sions (elastic#126470)

* [Discover] fix cloud test for encoded param in context

* [Discover] improve test description wording

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dimaanj dimaanj mentioned this pull request Mar 18, 2022
Merged
dimaanj added a commit to dimaanj/kibana that referenced this pull request Mar 18, 2022
@dimaanj @kibanamachine
[Discover] Fix "encoded URL params in context page" cloud test permis…
0a92e30 
…sions (elastic#126470)

* [Discover] fix cloud test for encoded param in context

* [Discover] improve test description wording

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5533748)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022
dimaanj added a commit that referenced this pull request Mar 18, 2022
@dimaanj @kibanamachine
[Discover] Fix "encoded URL params in context page" cloud test permis…
00e6244 
…sions (#126470) (#128052)

* [Discover] fix cloud test for encoded param in context

* [Discover] improve test description wording

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5533748)
dimaanj added a commit to dimaanj/kibana that referenced this pull request Mar 31, 2022
@dimaanj
[Discover] Fix "encoded URL params in context page" cloud test permis…
1b03590 
…sions (elastic#126470)

* [Discover] fix cloud test for encoded param in context

* [Discover] improve test description wording

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5533748)

# Conflicts:
#	test/functional/config.js
@dimaanj dimaanj mentioned this pull request Mar 31, 2022
Merged
dimaanj added a commit that referenced this pull request Mar 31, 2022
@dimaanj
[Discover] Fix "encoded URL params in context page" cloud test permis…
9f14188 
…sions (#126470) (#129033)

* [Discover] fix cloud test for encoded param in context

* [Discover] improve test description wording

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5533748)

# Conflicts:
#	test/functional/config.js
@jughosta jughosta mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal approved these changes

+1 more reviewer

@liza-mae liza-mae liza-mae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dimaanj dimaanj

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.1.0 v8.2.0

Projects

None yet

Milestone

No milestone

6 participants

@dimaanj @kertal @elasticmachine @kibana-ci @kibanamachine @liza-mae