Skip to content

[APM]Remove observer-version-major from apm queries#125962

Merged
MiriamAparicio merged 5 commits intoelastic:mainfrom
MiriamAparicio:remove-observer-version-major-filter-from-queries
Feb 22, 2022
Merged

[APM]Remove observer-version-major from apm queries#125962
MiriamAparicio merged 5 commits intoelastic:mainfrom
MiriamAparicio:remove-observer-version-major-filter-from-queries

Conversation

@MiriamAparicio
Copy link
Copy Markdown
Contributor

@MiriamAparicio MiriamAparicio commented Feb 17, 2022

Closes #125621

@MiriamAparicio MiriamAparicio added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Feb 17, 2022
@MiriamAparicio MiriamAparicio requested a review from a team February 17, 2022 16:22
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner February 17, 2022 16:22
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2022

Pinging @elastic/apm-ui (Team:apm)

@MiriamAparicio MiriamAparicio removed the request for review from a team February 17, 2022 16:25
@MiriamAparicio
Copy link
Copy Markdown
Contributor Author

MiriamAparicio commented Feb 21, 2022

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 21, 2022

ignoring request to update branch, pull request is closed

@MiriamAparicio MiriamAparicio force-pushed the remove-observer-version-major-filter-from-queries branch from 2b03ee1 to e6f3575 Compare February 21, 2022 09:27
@MiriamAparicio MiriamAparicio force-pushed the remove-observer-version-major-filter-from-queries branch from e6f3575 to 173f0dc Compare February 21, 2022 10:07
dgieselaar
dgieselaar reviewed Feb 21, 2022
View reviewed changes
x-pack/plugins/apm/server/routes/services/get_services/index.ts Outdated
}) {
return withApmSpan('get_services', async () => {
const [items, hasLegacyData] = await Promise.all([
const [items] = await Promise.all([
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be rewritten without a Promise.all() call.

dgieselaar
dgieselaar approved these changes Feb 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a single comment about unnecessary usage of Promise.all(). Thanks Miriam!

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 21, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB -34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit eb05eb5 into elastic:main Feb 22, 2022
@MiriamAparicio MiriamAparicio deleted the remove-observer-version-major-filter-from-queries branch February 22, 2022 11:12
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 22, 2022

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 125962

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 24, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125962 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 25, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125962 or prevent reminders by adding the backport:skip label.

@MiriamAparicio MiriamAparicio added the backport:skip This PR does not require backporting label Feb 28, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@MiriamAparicio
[APM]Remove observer-version-major from apm queries (elastic#125962)
5c8c928 
* [APM]Remove observer-version-major from apm queries

* Remove constant from apm, not observability

* fix tests and ts types

* remove Promise.all()

* fix types
@sorenlouv sorenlouv mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgieselaar dgieselaar dgieselaar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Remove observer.version_major filter

5 participants

@MiriamAparicio @elasticmachine @kibanamachine @kibana-ci @dgieselaar