Skip to content

[8.1] Move saved objects loader to dashboard plugin (#124708)#125203

Merged
kibanamachine merged 3 commits intoelastic:8.1from
kibanamachine:backport/8.1/pr-124708
Feb 15, 2022
Merged

[8.1] Move saved objects loader to dashboard plugin (#124708)#125203
kibanamachine merged 3 commits intoelastic:8.1from
kibanamachine:backport/8.1/pr-124708

Conversation

@kibanamachine
Copy link
Contributor

Backport

This is an automatic backport to 8.1 of:

Questions ?

Please refer to the Backport tool documentation

* Move SavedObjectLoader into the dashboard plugin

* Remove old comment recommending savedobjectloader

* Fix types

(cherry picked from commit 00fb06c)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 10, 2022
@kibanamachine kibanamachine enabled auto-merge (squash) February 10, 2022 09:37
@rudolf
Copy link
Contributor

rudolf commented Feb 15, 2022

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit 05f8001 into elastic:8.1 Feb 15, 2022
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 260 262 +2
savedObjects 39 37 -2
total -0

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
savedObjects 177 151 -26

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
savedObjects 3 2 -1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 13 14 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 66.1KB 67.5KB +1.3KB
savedObjects 30.5KB 29.1KB -1.4KB
total -98.0B
Unknown metric groups

API count

id before after diff
savedObjects 221 192 -29

References to deprecated APIs

id before after diff
dashboard 100 90 -10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rudolf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants