Skip to content

[IM] Add missing values to the index details flyout#124731

Merged
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:im_fix_flyout
Feb 7, 2022
Merged

[IM] Add missing values to the index details flyout#124731
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:im_fix_flyout

Conversation

@yuliacech
Copy link
Contributor

Fixes #123714

Summary

This PR adds back missing values for "Docs Deleted" and "Primary Storage Size" displayed in the index details flyout. These values have probably been removed in this PR#28855 but can found in Index Stats API.

How to test

  1. Start ES and Kibana with yarn es snapshot and yarn start
  2. Add some sample data
  3. Navigate to Index Management and check index details flyout
  4. To delete a document, first use GET /<index_name>/_search in Console and copy _id of any document in the hits array, then use DELETE /kibana_sample_data_ecommerce/_doc/<doc_id>?refresh=true to delete a document
  5. Check that the value in the flyout is updated (NOTE: For some reason, the count for deleted docs is incremented by 2 for each deleted document. It has something to do with index refresh and changes if the index is flushed)

Screenshot

Screenshot 2022-02-04 at 18 00 14

Checklist

Release Note

In Index Management app, index details again display previously missing values for the number of deleted documents and the primary storage size.

@yuliacech yuliacech added release_note:fix Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.1.0 v7.17.1 labels Feb 4, 2022
@yuliacech yuliacech requested a review from a team as a code owner February 4, 2022 17:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexManagement 164 170 +6
Unknown metric groups

API count

id before after diff
indexManagement 169 175 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Verified locally. Thanks for fixing this!

@yuliacech
Copy link
Contributor Author

Thanks a lot for the review, @alisonelizabeth!

@yuliacech yuliacech added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 7, 2022
@yuliacech yuliacech merged commit 3302843 into elastic:main Feb 7, 2022
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.2.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2022
…n the index details flyout (elastic#124731)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3302843)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0:
- [Index management] Prepare support Index template V2 format (#61588)
8.1
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 124731

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 7, 2022
…n the index details flyout (#124731) (#124859)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3302843)

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
@yuliacech
Copy link
Contributor Author

I'm removing 7.17.1 and 8.0.0 labels and won't backport the fix to those branches. The reason for that is this PR (remove _cat APIs) that was only backported to 8.1.0 and causes merge conflicts for 7.17 and 8.0 branches.

@yuliacech yuliacech deleted the im_fix_flyout branch March 7, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Index Management Index and index templates UI release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.1.0 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Index Management] Missing values in index details flyout

5 participants