Skip to content

[8.0] Fix validation for duration vars on APM configuration settings (#124336)#124673

Closed
MiriamAparicio wants to merge 2 commits intoelastic:8.0from
MiriamAparicio:backport/8.0/pr-124336
Closed

[8.0] Fix validation for duration vars on APM configuration settings (#124336)#124673
MiriamAparicio wants to merge 2 commits intoelastic:8.0from
MiriamAparicio:backport/8.0/pr-124336

Conversation

@MiriamAparicio
Copy link
Copy Markdown
Contributor

Backport

This is an automatic backport to 8.0 of:

Questions ?

Please refer to the Backport tool documentation

…ic#124336)

* Fix validation for duration vars on apm configuration settings

* Add unit test and just do the fix if the base package is apm

(cherry picked from commit c51daa7)

# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/edit_package_policy_page/index.tsx
@MiriamAparicio MiriamAparicio added the backport This PR is a backport of another PR label Feb 4, 2022
@MiriamAparicio MiriamAparicio enabled auto-merge (squash) February 4, 2022 10:59
@MiriamAparicio
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 15, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 560 561 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +16.0B
fleet 647.1KB 647.4KB +376.0B
total +392.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 112.8KB 113.0KB +208.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

auto-merge was automatically disabled February 15, 2022 10:49

Pull request was closed

@MiriamAparicio MiriamAparicio deleted the backport/8.0/pr-124336 branch February 15, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants