Skip to content

[8.1] Fix validation for duration vars on APM configuration settings (#124336)#124514

Merged
kibanamachine merged 4 commits intoelastic:8.1from
kibanamachine:backport/8.1/pr-124336
Feb 4, 2022
Merged

[8.1] Fix validation for duration vars on APM configuration settings (#124336)#124514
kibanamachine merged 4 commits intoelastic:8.1from
kibanamachine:backport/8.1/pr-124336

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Feb 3, 2022

Backport

This is an automatic backport to 8.1 of:

Questions ?

Please refer to the Backport tool documentation

@MiriamAparicio @kibanamachine
Fix validation for duration vars on APM configuration settings (elast…
a2bc10e 
…ic#124336)

* Fix validation for duration vars on apm configuration settings

* Add unit test and just do the fix if the base package is apm

(cherry picked from commit c51daa7)
@kibanamachine kibanamachine requested a review from a team February 3, 2022 12:00
@kibanamachine kibanamachine requested a review from a team as a code owner February 3, 2022 12:00
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 3, 2022
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 3, 2022
@kibanamachine kibanamachine enabled auto-merge (squash) February 3, 2022 12:00
@kibanamachine kibanamachine mentioned this pull request Feb 3, 2022
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 3, 2022

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 3, 2022

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Copy Markdown
Contributor

juliaElastic commented Feb 4, 2022

@elasticmachine merge upstream

@juliaElastic
Copy link
Copy Markdown
Contributor

juliaElastic commented Feb 4, 2022 •
edited
Loading

the failing build is due to a cypress issue, I've fixing that here #124658

@juliaElastic
Copy link
Copy Markdown
Contributor

juliaElastic commented Feb 4, 2022

@elasticmachine merge upstream

@juliaElastic
Copy link
Copy Markdown
Contributor

juliaElastic commented Feb 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 4, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 565 566 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +16.0B
fleet 659.0KB 659.3KB +372.0B
total +388.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 109.4KB 109.6KB +208.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MiriamAparicio

@kibanamachine kibanamachine merged commit 3fb863a into elastic:8.1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@MiriamAparicio MiriamAparicio

Labels

backport This PR is a backport of another PR Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kibanamachine @elasticmachine @juliaElastic @kibana-ci @MiriamAparicio