Skip to content

[Transform] Fix redirect to the wizard #124337

Merged
darnautov merged 1 commit intoelastic:mainfrom
darnautov:transform-120242-fix-browser-history
Feb 2, 2022
Merged

[Transform] Fix redirect to the wizard #124337
darnautov merged 1 commit intoelastic:mainfrom
darnautov:transform-120242-fix-browser-history

Conversation

@darnautov
Copy link
Copy Markdown
Contributor

@darnautov darnautov commented Feb 2, 2022

Summary

Fixes #120242

Fixes redirect to the Transform wizard by pushing a change to the browser history instead of replacing it.

Screen.Recording.2022-02-02.at.13.43.00.mov

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov force-pushed the transform-120242-fix-browser-history branch from a0d562a to 643fd68 Compare February 2, 2022 12:47
@darnautov darnautov added auto-backport Deprecated - use backport:version if exact versions are needed v7.17.1 v8.0.0 and removed v8.0.1 labels Feb 2, 2022
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 374.1KB 374.1KB +8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit de9f1d4 into elastic:main Feb 2, 2022
@darnautov darnautov deleted the transform-120242-fix-browser-history branch February 2, 2022 14:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 2, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.0
8.2 The branch "8.2" is invalid or doesn't exist
7.17

How to fix

Re-run the backport manually:

node scripts/backport --pr 124337

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@darnautov darnautov removed the v8.2.0 label Feb 2, 2022
kibanamachine added a commit that referenced this pull request Feb 2, 2022
(cherry picked from commit de9f1d4)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 2, 2022
(cherry picked from commit de9f1d4)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Transforms Transforms :ml release_note:fix v7.17.1 v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Transforms: Hitting browser back button moves user to rollups instead of transform

6 participants