Skip to content

[7.17] [Dashboard] Fix blank panel save and display issue. (#120815)#124295

Merged
ThomThomson merged 4 commits intoelastic:7.17from
ThomThomson:backport/7.17/pr-120815
Feb 2, 2022
Merged

[7.17] [Dashboard] Fix blank panel save and display issue. (#120815)#124295
ThomThomson merged 4 commits intoelastic:7.17from
ThomThomson:backport/7.17/pr-120815

Conversation

@ThomThomson
Copy link
Copy Markdown
Contributor

Backport

This is an automatic backport to 7.17 of:

Questions ?

Please refer to the Backport tool documentation

* Added special case to panel comparison.

* Fixed panel title behaviour when linking/unlinking to/from the library.

* Added panel title test suite.

* Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking.

* Adjusted use of 'setValue()' based on feedback from @dmlemeshko

* Refractor test suite.

* Improved code for removal of title on library link.

(cherry picked from commit b6013d1)

# Conflicts:
#	src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx
@ThomThomson ThomThomson merged commit 4f2881e into elastic:7.17 Feb 2, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 73.0KB 73.1KB +32.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 168.0KB 168.0KB +65.0B
embeddable 69.8KB 69.9KB +130.0B
total +195.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants