Skip to content

[7.17] [Dashboard][Embeddable] Create Explicit Diffing System (#121241)#124293

Merged
ThomThomson merged 3 commits intoelastic:7.17from
ThomThomson:backport/7.17/pr-121241
Feb 2, 2022
Merged

[7.17] [Dashboard][Embeddable] Create Explicit Diffing System (#121241)#124293
ThomThomson merged 3 commits intoelastic:7.17from
ThomThomson:backport/7.17/pr-121241

Conversation

@ThomThomson
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson commented Feb 1, 2022

Backport

This is an automatic backport to 7.17 of:

Questions ?

Please refer to the Backport tool documentation

Closes #123857
Closes #122760

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: nreese <reese.nathan@elastic.co>
(cherry picked from commit 944ccf1)

# Conflicts:
#	src/plugins/dashboard/public/application/lib/diff_dashboard_state.ts
#	x-pack/plugins/maps/server/plugin.ts
@ThomThomson ThomThomson added the backport This PR is a backport of another PR label Feb 1, 2022
@ThomThomson ThomThomson enabled auto-merge (squash) February 1, 2022 20:59
@ThomThomson ThomThomson merged commit 1da55fa into elastic:7.17 Feb 2, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 207 266 +59
embeddable 77 78 +1
maps 785 786 +1
total +61

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 393 403 +10
maps 196 198 +2
total +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 141.4KB 171.8KB +30.4KB
lens 1.0MB 1.0MB -118.0B
maps 2.7MB 2.7MB +966.0B
total +31.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 167.9KB 168.0KB +58.0B
embeddable 68.7KB 69.8KB +1.1KB
total +1.1KB
Unknown metric groups

API count

id before after diff
embeddable 469 482 +13
maps 197 199 +2
total +15

References to deprecated APIs

id before after diff
dashboard 244 231 -13

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants