Skip to content

[Remote Clusters] Fix table filtering when there are clusters with proxy mode#124220

Merged
sabarasaba merged 4 commits intoelastic:mainfrom
sabarasaba:remote_clusters/fix_table_search_for_clusters_with_proxy_mode
Feb 3, 2022
Merged

[Remote Clusters] Fix table filtering when there are clusters with proxy mode#124220
sabarasaba merged 4 commits intoelastic:mainfrom
sabarasaba:remote_clusters/fix_table_search_for_clusters_with_proxy_mode

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Feb 1, 2022 •
edited
Loading

Fixes #123606

Summary

The remote clusters table filtering wasnt built in mind with support for proxy mode. The filtering function always expects that a cluster will have a seeds[] prop but when you create a cluster with proxy mode instead of having a seeds[] it has a proxyAddress.

This PR fixes that and also adds support for filtering by proxyAddress.

How to test

  1. Start elasticsearch and kibana
  2. Navigate to Stack Management -> Remote Clusters
  3. Add a few remote clusters with proxy mode and others without
  4. Verify that the filtering works

@sabarasaba sabarasaba self-assigned this Feb 1, 2022
@sabarasaba sabarasaba added auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// and removed backport:skip This PR does not require backporting auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 1, 2022
@sabarasaba sabarasaba added v7.15.0 v7.16.0 v7.17.0 v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 1, 2022
@sabarasaba sabarasaba changed the title [Remote Clusters] Fix table search for clusters with proxy mode [Remote Clusters] Fix table filtering when there are clusters with proxy mode Feb 1, 2022
@sabarasaba sabarasaba marked this pull request as ready for review February 1, 2022 14:38
@sabarasaba sabarasaba requested a review from a team as a code owner February 1, 2022 14:38
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 1, 2022

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@sabarasaba sabarasaba requested a review from yuliacech February 1, 2022 14:38
@sabarasaba sabarasaba added the release_note:skip Skip the PR/issue when compiling release notes label Feb 1, 2022
yuliacech
yuliacech approved these changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing the remote clusters search, @sabarasaba!
I tested locally and everything works as expected. I don't want to block you on this, but could you please add a couple of tests for "seeds" and "proxyAddress" searches (in a separate PR if needed)?
Also, I'm not sure if we need v7.15.0 and v7.16.0 labels? Maybe if there is another v7.16 patch, we could backport to 7.16.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 2, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
remoteClusters 83.5KB 83.6KB +72.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Feb 3, 2022

According to the release schedule there are no upcoming 7.15.x and 7.16.x patches, so merging this directly into 7.17 and 8.x.

@sabarasaba sabarasaba merged commit 5e3d0b2 into elastic:main Feb 3, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2022
@sabarasaba @kibanamachine
[Remote Clusters] Fix table filtering when there are clusters with pr…
8db43fb 
…oxy mode (elastic#124220)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)
@kibanamachine kibanamachine mentioned this pull request Feb 3, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2022
@sabarasaba @kibanamachine
[Remote Clusters] Fix table filtering when there are clusters with pr…
e67e760 
…oxy mode (elastic#124220)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)
@kibanamachine kibanamachine mentioned this pull request Feb 3, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2022
@sabarasaba @kibanamachine
[Remote Clusters] Fix table filtering when there are clusters with pr…
7a23f63 
…oxy mode (elastic#124220)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)
@kibanamachine kibanamachine mentioned this pull request Feb 3, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 3, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 8.1
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 3, 2022
@kibanamachine @sabarasaba
[Remote Clusters] Fix table filtering when there are clusters with pr…
7bcead5 
…oxy mode (#124220) (#124491)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
kibanamachine added a commit that referenced this pull request Feb 3, 2022
@kibanamachine @sabarasaba
[Remote Clusters] Fix table filtering when there are clusters with pr…
a818054 
…oxy mode (#124220) (#124493)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
kibanamachine added a commit that referenced this pull request Feb 3, 2022
@kibanamachine @sabarasaba
[Remote Clusters] Fix table filtering when there are clusters with pr…
faa6d6d 
…oxy mode (#124220) (#124492)

* Fix table search for clusters with proxy mode

* commit using @elastic.co

* Fix tests and add docs

* Add tests for different kinds of search

(cherry picked from commit 5e3d0b2)

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sabarasaba sabarasaba

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.17.0 v8.0.0 v8.1.0 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remote cluster search broken

5 participants

@sabarasaba @elasticmachine @kibana-ci @kibanamachine @yuliacech