[Reporting] Correct CSV and ILM tests when run against ES 8.0#123981
Merged
tsullivan merged 13 commits intoelastic:7.17from Feb 3, 2022
Merged
[Reporting] Correct CSV and ILM tests when run against ES 8.0#123981tsullivan merged 13 commits intoelastic:7.17from
tsullivan merged 13 commits intoelastic:7.17from
Conversation
tsullivan
force-pushed
the
reporting/test-reenable-7.17
branch
from
fdfd4b1 to
d8f2eb6
Compare
tsullivan
force-pushed
the
reporting/test-reenable-7.17
branch
from
d8f2eb6 to
5f33d98
Compare
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
jloleysens
reviewed
Feb 2, 2022
| { | ||
| names: ['.reporting-*'], | ||
| privileges: ['all', 'manage'], | ||
| allow_restricted_indices: true, |
Contributor
There was a problem hiding this comment.
I think this should be forward-ported to 8.x
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
changed the title
jloleysens
reviewed
Feb 3, 2022
Comment on lines
+43
to
+44
| allow_restricted_indices: true, | ||
| } as SecurityHasPrivilegesIndexPrivilegesCheck, |
Contributor
There was a problem hiding this comment.
This should also be forward ported (and the import statement above)
Contributor
There was a problem hiding this comment.
Ah nvm, this is already the case in main 🤦🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #123082